Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab.com/pycqa/flake8 no longer exists #2309

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

jinwonkim93
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix for pre-commit
flake8 no longer exist in gitlab.
changing it to github fix the problem?

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@MeowZheng MeowZheng reopened this Nov 15, 2022
@MeowZheng
Copy link
Collaborator

MeowZheng commented Nov 15, 2022

we are maintaining master branch and dev-1.x branch, and #2308 just fix the dev-1.x, so we need this pr to fix master.

@jinwonkim93
Copy link
Author

duplication of #2308

@jinwonkim93
Copy link
Author

we are maintaining master branch and dev-1.x branch, and #2308 just fix the dev-1.x, so we need this pr to fix master.

oh okay

@MeowZheng
Copy link
Collaborator

we are maintaining master branch and dev-1.x branch, and #2308 just fix the dev-1.x, so we need this pr to fix master.

oh okay

thanks for your consistent support of mmseg! :)

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 88.97% // Head: 88.97% // No change to project coverage 👍

Coverage data is based on head (cdd5896) compared to base (6b4c7ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2309   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         146      146           
  Lines        8746     8746           
  Branches     1474     1474           
=======================================
  Hits         7782     7782           
  Misses        722      722           
  Partials      242      242           
Flag Coverage Δ
unittests 88.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 180ad08 into open-mmlab:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants