Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix KNet IterativeDecodeHead bug in master branch #2333

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

MengzhangLI
Copy link
Contributor

@MengzhangLI MengzhangLI commented Nov 22, 2022

Fix: #2325

Motivation

In latest master branch, it would raise error when training K-Net like below:
image

After adding self.out_channels = self.num_classes in IterativeDecodeHead initialization function, this bug would be fixed:

image

@MengzhangLI MengzhangLI changed the title [Fix] Fix KNet IterativeDecodeHead bug in v0.x branch [Fix] Fix KNet IterativeDecodeHead bug in master branch Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 88.97% // Head: 88.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9144071) compared to base (180ad08).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2333   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         146      146           
  Lines        8746     8747    +1     
  Branches     1474     1474           
=======================================
+ Hits         7782     7783    +1     
  Misses        722      722           
  Partials      242      242           
Flag Coverage Δ
unittests 88.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/knet_head.py 93.75% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 77dbecd into open-mmlab:master Dec 1, 2022
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Jan 9, 2023
@MengzhangLI MengzhangLI deleted the fix_knet_master branch January 9, 2023 14:31
MeowZheng pushed a commit that referenced this pull request Jan 11, 2023
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in knet_head
3 participants