Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enchancement] Delete mmcls in runtime.txt in dev-1.x #2368

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

MengzhangLI
Copy link
Contributor

Motivation

Delete mmcls in runtime.txt which lists the minimally packages MMSegmentation codebase needs to run correctly.

Also delete build.txt in setup.py which does not exist in dev-1.x branch.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 83.17% // Head: 83.19% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (168dadd) compared to base (9451081).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2368      +/-   ##
===========================================
+ Coverage    83.17%   83.19%   +0.01%     
===========================================
  Files          141      141              
  Lines         7971     7998      +27     
  Branches      1193     1198       +5     
===========================================
+ Hits          6630     6654      +24     
- Misses        1157     1158       +1     
- Partials       184      186       +2     
Flag Coverage Δ
unittests 83.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/transforms.py 96.42% <0.00%> (-0.49%) ⬇️
mmseg/datasets/__init__.py 100.00% <0.00%> (ø)
mmseg/datasets/transforms/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 90c816b into open-mmlab:dev-1.x Dec 1, 2022
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Dec 30, 2022
* [Enchancement] Delete mmcls in runtime.txt in dev-1.x

* fix mmcv minimal version
@MengzhangLI MengzhangLI deleted the delete_mmlcs_runtime branch January 9, 2023 14:31
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
There isn't a space between the "Scope" paragraph and "Ethical Guidelines", here: https://huggingface.co/docs/diffusers/main/en/conceptual/ethical_guidelines , yet I can't see that in the preview. In this PR, I'm simply adding some spaces in the hopes that it resolves the issue.....
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
* [Enchancement] Delete mmcls in runtime.txt in dev-1.x

* fix mmcv minimal version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants