-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed deadlock issue related with MMSegWandbHook #2398
Fixed deadlock issue related with MMSegWandbHook #2398
Conversation
There was already a similar commit on mmcls open-mmlab/mmpretrain#1242, which I didn't know! (this commit was only 5 days ago, too.) |
Codecov ReportBase: 88.97% // Head: 88.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2398 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 146 146
Lines 8747 8749 +2
Branches 1474 1474
==========================================
+ Hits 7783 7784 +1
- Misses 722 723 +1
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for your contribution, we're working on testing this modification. |
0a608a0
to
e2fd5c0
Compare
Co-authored-by: WangYudong <yudong.wang@akane.waseda.jp>
I've verified my commit. Nothing else has changed. (Edit) |
e2fd5c0
to
77dbecd
Compare
This modification works well. |
Co-authored-by: WangYudong <yudong.wang@akane.waseda.jp>
* add: inversion to pix2pix zero docs. * add: comment to emphasize the use of flan to generate. * more nits.
Co-authored-by: WangYudong <yudong.wang@akane.waseda.jp>
Co-authored-by: WangYudong yudong.wang@akane.waseda.jp
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Bug report on mmseg: #2137
Bug report on mmdet: open-mmlab/mmdetection#8145.
deadlock occurs on both mmseg and mmdet, for the same reason.
To summarize problem, when we use
MMSegWandbHook
afterTextLoggerHook
, deadlock problem occurs. These are because of same reason and I summarized the reason in open-mmlab/mmdetection#8145 (comment) here.Modification
Made MMSegWandbHook to clear
runner.log_buffer
on every process, including process for GPU 1,2,3...BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist