Skip to content

[Docs] add deeplabv3 model structure #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 17, 2023
Merged

Conversation

BLUE-coconut
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 83.42% // Head: 83.33% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (9665cfc) compared to base (6d8ba3b).
Patch has no changes to coverable lines.

❗ Current head 9665cfc differs from pull request most recent head fa05a05. Consider uploading reports for the commit fa05a05 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2426      +/-   ##
===========================================
- Coverage    83.42%   83.33%   -0.09%     
===========================================
  Files          145      143       -2     
  Lines         8451     8127     -324     
  Branches      1259     1211      -48     
===========================================
- Hits          7050     6773     -277     
+ Misses        1193     1165      -28     
+ Partials       208      189      -19     
Flag Coverage Δ
unittests 83.33% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/timm_backbone.py 45.83% <0.00%> (-37.51%) ⬇️
mmseg/models/segmentors/base.py 87.87% <0.00%> (-2.27%) ⬇️
mmseg/models/decode_heads/mask2former_head.py 89.65% <0.00%> (-0.18%) ⬇️
mmseg/models/decode_heads/maskformer_head.py 93.75% <0.00%> (-0.10%) ⬇️
mmseg/datasets/__init__.py 100.00% <0.00%> (ø)
mmseg/models/segmentors/__init__.py 100.00% <0.00%> (ø)
mmseg/datasets/transforms/__init__.py 100.00% <0.00%> (ø)
mmseg/datasets/synapse.py
mmseg/models/segmentors/seg_tta.py
mmseg/utils/class_names.py 85.93% <0.00%> (+2.11%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RangeKing
Copy link
Contributor

RangeKing commented Dec 21, 2022

  1. 图中模块里相同类型的字体类型和字体颜色要统一(例如maxpool2d里的就不符合)
  2. 注意各种对齐,具体见下图
    image
  3. Details 里加入 bottleneck 内部细节

@BLUE-coconut
Copy link
Contributor Author

已修改

@BLUE-coconut
Copy link
Contributor Author

deeplabv3_r50-d8_structure_01(7)
已修改

@MeowZheng MeowZheng force-pushed the dev-1.x branch 4 times, most recently from 4c28e1e to 115552d Compare December 30, 2022 14:56
@MeowZheng MeowZheng added the High Priority from Community This issue/pr needs more attention and higher priority than default developing plan label Jan 3, 2023
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please solve the conflict

Copy link
Contributor

@RangeKing RangeKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeowZheng MeowZheng merged commit 6d63e77 into open-mmlab:dev-1.x Mar 17, 2023
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
Deprecation warning should only hit at version 0.15
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority from Community This issue/pr needs more attention and higher priority than default developing plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants