Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docstring error in the class PascalContextDataset59 #2450

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

Spritea
Copy link

@Spritea Spritea commented Dec 30, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The docstring in the class PascalContextDataset59 is misleading. Try to fix it.

Modification

The docstring in the class PascalContextDataset59 is changed.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Dec 30, 2022

CLA assistant check
All committers have signed the CLA.

@MeowZheng MeowZheng added the High Priority from Community This issue/pr needs more attention and higher priority than default developing plan label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 88.97% // Head: 88.97% // No change to project coverage 👍

Coverage data is based on head (40f94a6) compared to base (2cbff70).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2450   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         146      146           
  Lines        8749     8749           
  Branches     1474     1474           
=======================================
  Hits         7784     7784           
  Misses        723      723           
  Partials      242      242           
Flag Coverage Δ
unittests 88.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/pascal_context.py 75.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 9625c9b into open-mmlab:master Jan 3, 2023
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Jan 9, 2023
…ab#2450)

## Motivation

The docstring in the class PascalContextDataset59 is misleading. Try to fix it.

## Modification

The docstring in the class PascalContextDataset59 is changed.
MeowZheng pushed a commit that referenced this pull request Jan 11, 2023
## Motivation

The docstring in the class PascalContextDataset59 is misleading. Try to fix it.

## Modification

The docstring in the class PascalContextDataset59 is changed.
huajiangjiangLi pushed a commit to pytorchuser/HDB-Seg that referenced this pull request Apr 12, 2023
…ab#2450)

## Motivation

The docstring in the class PascalContextDataset59 is misleading. Try to fix it.

## Modification

The docstring in the class PascalContextDataset59 is changed.
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority from Community This issue/pr needs more attention and higher priority than default developing plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants