Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Projects] Add 'Projects/' folder, and the first example project in 0.x #2457

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

xiexinch
Copy link
Collaborator

@xiexinch xiexinch commented Jan 6, 2023

Motivation

Introducing new models and features into OpenMMLab's algorithm libraries has long been complained to be troublesome due to the rigorous requirements on code quality, which could hinder the fast iteration of SOTA models and might discourage potential contributors from sharing their latest outcome here.

Ref: #2412

Modification

This PR adds a new projects/ folder, which will be a place for some experimental models/features. Implementations inside might be not quite perfect but already fine to produce some exciting results. We hope that this PR can help us better embrace the contribution from our community. We also add the first example project to illustrate what we expect a good project to have.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 88.97% // Head: 88.91% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (e712ce6) compared to base (9625c9b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2457      +/-   ##
==========================================
- Coverage   88.97%   88.91%   -0.06%     
==========================================
  Files         146      146              
  Lines        8749     8703      -46     
  Branches     1474     1474              
==========================================
- Hits         7784     7738      -46     
  Misses        723      723              
  Partials      242      242              
Flag Coverage Δ
unittests 88.91% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/segmentors/base.py 56.03% <0.00%> (-3.17%) ⬇️
mmseg/core/hook/wandblogger_hook.py 16.19% <0.00%> (-1.74%) ⬇️
mmseg/models/decode_heads/cascade_decode_head.py 92.30% <0.00%> (-0.55%) ⬇️
mmseg/models/necks/fpn.py 57.14% <0.00%> (-0.55%) ⬇️
mmseg/ops/encoding.py 91.66% <0.00%> (-0.44%) ⬇️
mmseg/models/backbones/resnest.py 83.72% <0.00%> (-0.25%) ⬇️
mmseg/models/losses/focal_loss.py 75.24% <0.00%> (-0.25%) ⬇️
mmseg/models/backbones/vit.py 90.64% <0.00%> (-0.22%) ⬇️
mmseg/datasets/cityscapes.py 85.00% <0.00%> (-0.19%) ⬇️
mmseg/models/losses/cross_entropy_loss.py 86.74% <0.00%> (-0.16%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think need to add # Copyright (c) OpenMMLab. All rights reserved. in the new files

@MeowZheng MeowZheng merged commit fd5c202 into open-mmlab:master Jan 9, 2023
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Jan 9, 2023
….x (open-mmlab#2457)

## Motivation

Introducing new models and features into OpenMMLab's algorithm libraries
has long been complained to be troublesome due to the rigorous
requirements on code quality, which could hinder the fast iteration of
SOTA models and might discourage potential contributors from sharing
their latest outcome here.

Ref: open-mmlab#2412

## Modification

This PR adds a new `projects/` folder, which will be a place for some
experimental models/features. Implementations inside might be not quite
perfect but already fine to produce some exciting results. We hope that
this PR can help us better embrace the contribution from our community.
We also add the first example project to illustrate what we expect a
good project to have.
MeowZheng pushed a commit that referenced this pull request Jan 11, 2023
….x (#2457)

## Motivation

Introducing new models and features into OpenMMLab's algorithm libraries
has long been complained to be troublesome due to the rigorous
requirements on code quality, which could hinder the fast iteration of
SOTA models and might discourage potential contributors from sharing
their latest outcome here.

Ref: #2412

## Modification

This PR adds a new `projects/` folder, which will be a place for some
experimental models/features. Implementations inside might be not quite
perfect but already fine to produce some exciting results. We hope that
this PR can help us better embrace the contribution from our community.
We also add the first example project to illustrate what we expect a
good project to have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants