Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix TTA resize scale #334

Merged
merged 3 commits into from
Jan 7, 2021
+7 −6
Merged

[Bug Fix] Fix TTA resize scale #334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4e4fc3
fix tta bug
yamengxi Jan 7, 2021
c2691db
modify as suggested
yamengxi Jan 7, 2021
6f5dfb3
fix test_tta bug
yamengxi Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmseg/datasets/pipelines/test_time_aug.py
View file
Original file line number Diff line number Diff line change
@@ -104,7 +104,7 @@ def __call__(self, results):
aug_data = []
if self.img_scale is None and mmcv.is_list_of(self.img_ratios, float):
h, w = results['img'].shape[:2]
img_scale = [(int(h * ratio), int(w * ratio))
img_scale = [(int(w * ratio), int(h * ratio))
for ratio in self.img_ratios]
else:
img_scale = self.img_scale
5 changes: 3 additions & 2 deletions mmseg/datasets/pipelines/transforms.py
View file
Original file line number Diff line number Diff line change
@@ -156,8 +156,9 @@ def _random_scale(self, results):

if self.ratio_range is not None:
if self.img_scale is None:
scale, scale_idx = self.random_sample_ratio(
results['img'].shape[:2], self.ratio_range)
h, w = results['img'].shape[:2]
scale, scale_idx = self.random_sample_ratio((w, h),
self.ratio_range)
else:
scale, scale_idx = self.random_sample_ratio(
self.img_scale[0], self.ratio_range)
6 changes: 3 additions & 3 deletions tests/test_data/test_tta.py
View file
Original file line number Diff line number Diff line change
@@ -108,7 +108,7 @@ def test_multi_scale_flip_aug():
)
tta_module = build_from_cfg(tta_transform, PIPELINES)
tta_results = tta_module(results.copy())
assert tta_results['scale'] == [(144, 256), (288, 512), (576, 1024)]
assert tta_results['scale'] == [(256, 144), (512, 288), (1024, 576)]
assert tta_results['flip'] == [False, False, False]

tta_transform = dict(
@@ -120,8 +120,8 @@ def test_multi_scale_flip_aug():
)
tta_module = build_from_cfg(tta_transform, PIPELINES)
tta_results = tta_module(results.copy())
assert tta_results['scale'] == [(144, 256), (144, 256), (288, 512),
(288, 512), (576, 1024), (576, 1024)]
assert tta_results['scale'] == [(256, 144), (256, 144), (512, 288),
(512, 288), (1024, 576), (1024, 576)]
assert tta_results['flip'] == [False, True, False, True, False, True]

tta_transform = dict(