Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Move train_cfg/test_cfg inside model #341

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

xvjiarui
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #341 (55fc5c6) into master (49515e7) will decrease coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   86.07%   86.04%   -0.03%     
==========================================
  Files          95       95              
  Lines        4789     4795       +6     
  Branches      778      779       +1     
==========================================
+ Hits         4122     4126       +4     
- Misses        519      520       +1     
- Partials      148      149       +1     
Flag Coverage Δ
unittests 86.04% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/builder.py 81.48% <60.00%> (-4.89%) ⬇️
mmseg/apis/inference.py 66.07% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49515e7...55fc5c6. Read the comment docs.

@xvjiarui xvjiarui merged commit faaf29e into open-mmlab:master Jan 20, 2021
@callzhang
Copy link

This broke the tutorial code in MMSegmentation_Tutorial.ipynb:
model = build_segmentor(cfg.model, train_cfg=cfg.train_cfg, test_cfg=cfg.test_cfg)
It would be great if you can also fix the demo.

@Brainkite
Copy link

This broke the tutorial code in MMSegmentation_Tutorial.ipynb:
model = build_segmentor(cfg.model, train_cfg=cfg.train_cfg, test_cfg=cfg.test_cfg)
It would be great if you can also fix the demo.

Since it's now stored in cfg.model just removing the parameters works:
model = build_segmentor(cfg.model)

bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* [Improvement] Move train_cfg/test_cfg inside model

* fixed config dict

* fixed config dict
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
* fix docstring

* check inflate_style in kwargs

* fix

* Update resnet3d.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants