pytorch metrics implementation #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 86.43% 86.46% +0.03%
==========================================
Files 97 97
Lines 4960 4964 +4
Branches 805 806 +1
==========================================
+ Hits 4287 4292 +5
+ Misses 518 517 -1
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Fix #408 |
Closed
xvjiarui
reviewed
Mar 22, 2021
mmseg/core/evaluation/metrics.py
Outdated
Comment on lines
77
to
78
| gt_seg_maps (list[ndarray]): list of ground truth segmentation | ||
| maps. |
There was a problem hiding this comment.
Suggested change
| gt_seg_maps (list[ndarray]): list of ground truth segmentation | |
| maps. | |
| gt_seg_maps (list[ndarray]): list of ground truth segmentation | |
| maps. |
There was a problem hiding this comment.
We may update the doc string since results and gt_seg_maps could be list of str now.
xvjiarui
reviewed
Mar 22, 2021
mmseg/core/evaluation/metrics.py
Outdated
| num_classes, | ||
| ignore_index, | ||
| num_classes: int, | ||
| ignore_index: int, |
There was a problem hiding this comment.
We may update the docstring since pred_label and label could be str now.
xvjiarui
reviewed
Mar 22, 2021
added 2 commits
March 23, 2021 14:33
xvjiarui
reviewed
Mar 25, 2021
mmseg/core/evaluation/metrics.py
Outdated
| torch.Tensor: The intersection of prediction and ground truth | ||
| histogram on all classes. | ||
| torch.Tensor: The union of prediction and ground truth histogram on | ||
| all classes. |
xvjiarui
reviewed
Mar 25, 2021
tests/test_metrics.py
Outdated
Comment on lines
174
to
179
| def save_arr(input_arrays: list, title: str, is_image: bool): | ||
| filenames = [] | ||
| PREFIX = './temp' | ||
| SUFFIX = '.png' if is_image else '.npy' | ||
| if not os.path.exists(PREFIX): | ||
| os.makedirs(PREFIX) |
There was a problem hiding this comment.
We may use python tempfile library https://docs.python.org/3/library/tempfile.html
xvjiarui
approved these changes
Mar 28, 2021
xvjiarui
reviewed
Mar 28, 2021
tests/test_metrics.py
Outdated
| labels = np.random.randint(0, num_classes, size=pred_size) | ||
| labels[:, 2, 5:10] = ignore_index | ||
|
|
||
| temp_dir = tempfile.TemporaryDirectory() |
There was a problem hiding this comment.
with statement is preferred. So we won't forget to clean up.
with tempfile.TemporaryDirectory() as temp_dir:
xvjiarui
approved these changes
Mar 29, 2021
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
* pytorch metrics impl and test * support list[str] input, delete unused test code and delete numpy version * modify input data type * add docstring and unitest of filename inputs * add indents in docstring and use tempfile lib to create dir * using with statement
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.