-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mIoU calculatiton range #471
Conversation
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 86.58% 86.50% -0.08%
==========================================
Files 97 97
Lines 4964 4966 +2
Branches 807 806 -1
==========================================
- Hits 4298 4296 -2
- Misses 514 517 +3
- Partials 152 153 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Could we add some test cases for this? |
For example, we may construct some test cases that fail in the previous version. |
We can use trained model file to test on both two version IoU calculation function. |
…e bug caused by torch.histc;
How does this PR affect mIoU of cityscapes and ADE20k? |
mIoU of cityscapes has a little bit wave and doesn't contain nan value. But mIoU of ADE20K has six nan classes. |
Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>
* Fix fence(IoU) = 0 when training on PascalContextDataset59; * Add a test case in test_metrics() of tests/test_metrics.py to test the bug caused by torch.histc; * Update tests/test_metrics.py Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com> Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>
…e) (open-mmlab#471) fix table formatting (add blank line)
Hi @Sennnnn !First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
* resolve comments * update changelog * add with_global option * f bug * + contiguous * update * add config w. context * test with_global * update README * update changelog
Pascal Context Dataset
Single-scale, No flip, mIoU test result:
before fix:
Cityscapes Dataset
Single-scale, No flip, mIoU test result:
ADE20K Dataset
Single-scale, No flip, mIoU test result:
before fix: