[Enhance] Replace data_dict calling 'img' key to support MMDet3D #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wuziyi616
changed the title
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
==========================================
+ Coverage 86.56% 86.60% +0.04%
==========================================
Files 99 99
Lines 5164 5160 -4
Branches 836 834 -2
==========================================
- Hits 4470 4469 -1
+ Misses 535 533 -2
+ Partials 159 158 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xvjiarui
reviewed
Apr 26, 2021
|
This PR is ready for review @xvjiarui. Thanks! |
Wuziyi616
commented
Apr 28, 2021
| @@ -97,7 +97,7 @@ def single_gpu_test(model, | |||
| result = np2tmp(result) | |||
| results.append(result) | |||
|
|
|||
| batch_size = data['img'][0].size(0) | |||
| batch_size = len(result) | |||
There was a problem hiding this comment.
Refer to open-mmlab/mmcv#987
xvjiarui
approved these changes
Apr 29, 2021
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
…n-mmlab#514) * remove dict calling img key for compatibility * fix unit test * infer batch size using len(result) to be consistent with mmcv
wjkim81
pushed a commit
to wjkim81/mmsegmentation
that referenced
this pull request
Dec 3, 2023
sibozhang
pushed a commit
to sibozhang/mmsegmentation
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am Ziyi, a developer from MMDet3D. In order to train/test 3D seg algorithms, I need to call functions from MMSeg. However, some functions in MMSeg calls
data['img'], which causesKeyErrorbecause we don't haveimg. I replace these calling with some workarounds and make it compatibility with MMDet3D. Hope you can approve it. Thanks.