Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto get version info and git hash #55

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Conversation

xvjiarui
Copy link
Collaborator

@xvjiarui xvjiarui commented Aug 7, 2020

No description provided.

@xvjiarui xvjiarui requested a review from hellock August 7, 2020 03:52
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #55 into master will decrease coverage by 0.12%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   81.50%   81.38%   -0.13%     
==========================================
  Files          71       72       +1     
  Lines        3158     3191      +33     
  Branches      493      500       +7     
==========================================
+ Hits         2574     2597      +23     
- Misses        496      504       +8     
- Partials       88       90       +2     
Flag Coverage Δ
#unittests 81.38% <74.07%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/decode_head.py 91.66% <0.00%> (ø)
mmseg/utils/collect_env.py 21.15% <50.00%> (ø)
mmseg/version.py 58.33% <58.33%> (ø)
mmseg/__init__.py 73.68% <73.68%> (-26.32%) ⬇️
mmseg/core/seg/sampler/ohem_pixel_sampler.py 94.59% <90.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f56eb...9a26dc4. Read the comment docs.

@hellock
Copy link
Member

hellock commented Aug 7, 2020

We may bump version to 0.5.1

@hellock
Copy link
Member

hellock commented Aug 7, 2020

Update the doc:
image

docs/install.md Outdated
@@ -54,10 +54,9 @@ pip install -e . # or "python setup.py develop"

Note:

1. In `dev` mode, the git commit id will be written to the version number with step *d*, e.g. 0.5.0+c415a2e. The version will also be saved in trained models.
It is recommended that you run step *d* each time you pull some updates from github. If C++/CUDA codes are modified, then this step is compulsory.
1. The git commit id will be written to the version number with step *d*, e.g. 0.5.0+c415a2e. The version will also be saved in trained models.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. The version number does not contain the git hash.

@@ -0,0 +1,18 @@
# Copyright (c) Open-MMLab. All rights reserved.

__version__ = '0.5.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog.

@hellock
Copy link
Member

hellock commented Aug 10, 2020

ping @xvjiarui

@hellock hellock merged commit 4e29452 into open-mmlab:master Aug 11, 2020
johnzja pushed a commit to johnzja/mmsegmentation that referenced this pull request Aug 19, 2020
* Auto get version info and git hash

* bump 0.5.1 and update doc

* fixed docs

* Add change log
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* Auto get version info and git hash

* bump 0.5.1 and update doc

* fixed docs

* Add change log
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
[Resnet] Merge glide resnet into general resnet
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Co-authored-by: lizz <363664470@qq.com>
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
Co-authored-by: lizz <innerlee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants