Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes to Dockerfile #607

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

amrit110
Copy link
Contributor

This PR adds a couple of fixes to Dockerfile.

  1. Fix typo in url to git repo in Dockerfile, while cloning
  2. Fix pip install command to use requirements file in top level dir (requirements/build.txt does not exist)

Fixes #595

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2021

CLA assistant check
All committers have signed the CLA.

@Junjun2016
Copy link
Collaborator

Hi @amrit110
Thanks for your kind PR.

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #607 (6c4e990) into master (8f8abe3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   85.45%   85.45%           
=======================================
  Files         101      101           
  Lines        5220     5220           
  Branches      840      840           
=======================================
  Hits         4461     4461           
  Misses        586      586           
  Partials      173      173           
Flag Coverage Δ
unittests 85.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8abe3...6c4e990. Read the comment docs.

@xvjiarui xvjiarui merged commit 458fc78 into open-mmlab:master Jun 19, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in the Dockerfile
4 participants