[Feature] Support ISA module #70

LayneH · 2020-08-16T04:00:47Z

No description provided.

CLAassistant · 2020-08-16T04:00:53Z

All committers have signed the CLA.

codecov · 2020-08-16T04:10:36Z

Codecov Report

Merging #70 (1cbdbea) into master (d35fbbd) will increase coverage by 0.06%.
The diff coverage is 96.07%.

❗ Current head 1cbdbea differs from pull request most recent head 274a7fa. Consider uploading reports for the commit 274a7fa to get more accurate results

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   88.90%   88.96%   +0.06%     
==========================================
  Files         110      111       +1     
  Lines        5928     5979      +51     
  Branches      950      953       +3     
==========================================
+ Hits         5270     5319      +49     
  Misses        465      465              
- Partials      193      195       +2

Flag	Coverage Δ
unittests	`88.94% <96.07%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmseg/models/decode_heads/isa_head.py	`96.00% <96.00%> (ø)`
mmseg/models/decode_heads/__init__.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35fbbd...274a7fa. Read the comment docs.

mmseg/models/decode_heads/__init__.py

mmseg/models/decode_heads/isa_head.py

Junjun2016 · 2021-07-04T18:55:16Z

Hi @LayneH
Could you please update this PR if your time is available?

LayneH · 2021-08-24T08:03:54Z

Hi, @xvjiarui @Junjun2016,

This PR has been updated according to the comments.

Junjun2016 · 2021-08-24T08:10:41Z

Hi @LayneH
Thanks for your contribution.
Could you please resolve the conflict?
And we will review it again.

configs/_base_/models/isanet_r50-d8.py

configs/isanet/README.md

mmseg/models/decode_heads/isa_head.py

Junjun2016

Please add unittests for mmseg/models/decode_heads/isa_head.py.
We will benchmark it recently.

Junjun2016 · 2021-08-24T08:29:04Z

configs/_base_/models/.isanet_r50-d8.py.swp should be removed.

Junjun2016 · 2021-08-24T08:35:32Z

Please add unittests for mmseg/models/decode_heads/isa_head.py.
We will benchmark it recently.

Refer to https://github.com/open-mmlab/mmsegmentation/blob/master/tests/test_models/test_heads/test_ocr_head.py.

mmseg/models/decode_heads/isa_head.py

Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn>

Junjun2016 · 2021-08-24T13:52:32Z

Hi @LayneH
The unittests are failed.
Please also refer to https://github.com/open-mmlab/mmsegmentation/blob/master/tests/test_models/test_heads/test_dnl_head.py.

LayneH · 2021-08-24T16:17:05Z

Hi @Junjun2016,
The issue has been fixed.

Junjun2016 · 2021-08-24T16:55:58Z

Hi @Junjun2016,
The issue has been fixed.

Ok, we will add benchmarks for ISA recently.

configs/isanet/isanet_r50-d8_512x512_160k_ade20k.py

configs/isanet/isanet_r50-d8_512x512_80k_ade20k.py

configs/isanet/isanet_r50-d8_769x769_40k_cityscapes.py

configs/isanet/isanet_r50-d8_769x769_80k_cityscapes.py

Junjun2016 · 2021-09-01T07:12:56Z

Please also fix the conflict.
We are running benchmark.
We will update the results when we finish it.

LayneH · 2021-09-01T07:55:18Z

Hi, the conflicts have been fixed.

…into pr70

xiexinch · 2021-09-07T04:50:24Z

Hi @Junjun2016
Results updated.

LayneH · 2021-09-07T10:29:34Z

@xiexinch @Junjun2016
Thank you for the benchmarking, the results seem to be consistent with those in our paper.

Junjun2016

Please add supported methods in README (English and Chinese).

* add isa module * use more readable names, add more comments and exp results * add unittests * remove redundant docstring * Apply suggestions from code review Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn> * fix unittest * Update configs * add results * update yml * Update README Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn> Co-authored-by: xiexinch <xinchen.xie@qq.com>

* update mid block * finish mid block

OpenMMLab-Assistant003 · 2023-04-07T02:54:03Z

Hi @LayneH！First of all, we want to express our gratitude for your significant PR in the MMSegmentation project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤ @LayneH

add isa module

5f12186

xvjiarui reviewed Aug 19, 2020

View reviewed changes

mmseg/models/decode_heads/__init__.py Outdated Show resolved Hide resolved

xvjiarui reviewed Aug 19, 2020

View reviewed changes

mmseg/models/decode_heads/isa_head.py Show resolved Hide resolved

xvjiarui reviewed Aug 19, 2020

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

xvjiarui reviewed Aug 19, 2020

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

xvjiarui reviewed Aug 19, 2020

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

xvjiarui reviewed Aug 19, 2020

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

use more readable names, add more comments and exp results

1c908ae

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

configs/_base_/models/isanet_r50-d8.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

configs/isanet/README.md Show resolved Hide resolved

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

mmseg/models/decode_heads/isa_head.py Show resolved Hide resolved

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

LayneH and others added 2 commits August 24, 2021 16:56

Merge branch 'master' into isa

f950c44

add unittests

99e3739

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Aug 24, 2021

View reviewed changes

mmseg/models/decode_heads/isa_head.py Outdated Show resolved Hide resolved

LayneH and others added 2 commits August 24, 2021 10:12

remove redundant docstring

6beb5c4

Apply suggestions from code review

e826970

Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn>

LayneH added 2 commits August 24, 2021 15:39

fix unittest

26fd132

Merge branch 'isa' of https://github.com/LayneH/mmsegmentation into isa

2858a06

Junjun2016 changed the title ~~add isa module~~ [Feature] Support ISA module Aug 24, 2021

Junjun2016 reviewed Sep 1, 2021

View reviewed changes

configs/isanet/isanet_r50-d8_512x512_160k_ade20k.py Outdated Show resolved Hide resolved

Junjun2016 requested changes Sep 1, 2021

View reviewed changes

configs/isanet/isanet_r50-d8_512x512_80k_ade20k.py Outdated Show resolved Hide resolved

configs/isanet/isanet_r50-d8_769x769_40k_cityscapes.py Outdated Show resolved Hide resolved

configs/isanet/isanet_r50-d8_769x769_80k_cityscapes.py Outdated Show resolved Hide resolved

LayneH and others added 2 commits September 1, 2021 07:47

Update configs

20b6e1a

Merge branch 'master' into isa

0b9c13d

xiexinch added 3 commits September 7, 2021 11:20

add results

4e7815a

Merge branch 'master' of https://github.com/open-mmlab/mmsegmentation …

d7623cf

…into pr70

update yml

da0a552

LayneH requested a review from Junjun2016 September 7, 2021 10:31

Junjun2016 requested changes Sep 7, 2021

View reviewed changes

Update README

274a7fa

LayneH requested a review from Junjun2016 September 7, 2021 12:29

Junjun2016 approved these changes Sep 7, 2021

View reviewed changes

xvjiarui approved these changes Sep 9, 2021

View reviewed changes

xvjiarui merged commit eb0baee into open-mmlab:master Sep 9, 2021

aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023

update mid block (open-mmlab#70)

94566e6

* update mid block * finish mid block

wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023

OChuman dataset (open-mmlab#70)

cfe773d

sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024

Polish data preparation codes (open-mmlab#70)

9a07fc2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Support ISA module #70

[Feature] Support ISA module #70

LayneH commented Aug 16, 2020

CLAassistant commented Aug 16, 2020 •

edited

Loading

codecov bot commented Aug 16, 2020 •

edited

Loading

Junjun2016 commented Jul 4, 2021

LayneH commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

Junjun2016 left a comment

Junjun2016 commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

LayneH commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

Junjun2016 commented Sep 1, 2021

LayneH commented Sep 1, 2021

xiexinch commented Sep 7, 2021

LayneH commented Sep 7, 2021

Junjun2016 left a comment

OpenMMLab-Assistant003 commented Apr 7, 2023

[Feature] Support ISA module #70

[Feature] Support ISA module #70

Conversation

LayneH commented Aug 16, 2020

CLAassistant commented Aug 16, 2020 • edited Loading

codecov bot commented Aug 16, 2020 • edited Loading

Codecov Report

Junjun2016 commented Jul 4, 2021

LayneH commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

Junjun2016 left a comment

Choose a reason for hiding this comment

Junjun2016 commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

LayneH commented Aug 24, 2021

Junjun2016 commented Aug 24, 2021

Junjun2016 commented Sep 1, 2021

LayneH commented Sep 1, 2021

xiexinch commented Sep 7, 2021

LayneH commented Sep 7, 2021

Junjun2016 left a comment

Choose a reason for hiding this comment

OpenMMLab-Assistant003 commented Apr 7, 2023

CLAassistant commented Aug 16, 2020 •

edited

Loading

codecov bot commented Aug 16, 2020 •

edited

Loading