Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] md2yml pre-commit hook #732

Merged
merged 7 commits into from
Jul 31, 2021
Merged

Conversation

xiexinch
Copy link
Collaborator

In this PR:

We add a pre-commit hook to call .dev/md2yml.py at a new commit, which will:

  • Update model metafiles according to the corresponding .md files.
  • Update model-index.yml file according to the metafiles.
  • Check if any file has been modified.

@xiexinch xiexinch requested a review from Junjun2016 July 27, 2021 09:59
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #732 (33ea60a) into master (4b218bc) will increase coverage by 0.06%.
The diff coverage is 85.71%.

❗ Current head 33ea60a differs from pull request most recent head a2f96a6. Consider uploading reports for the commit a2f96a6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   85.28%   85.35%   +0.06%     
==========================================
  Files         107      107              
  Lines        5818     5823       +5     
  Branches      952      952              
==========================================
+ Hits         4962     4970       +8     
+ Misses        673      672       -1     
+ Partials      183      181       -2     
Flag Coverage Δ
unittests 85.33% <85.71%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/resnet.py 99.28% <ø> (ø)
mmseg/models/backbones/swin.py 86.89% <50.00%> (+0.04%) ⬆️
mmseg/models/necks/fpn.py 54.54% <66.66%> (+0.59%) ⬆️
mmseg/models/backbones/unet.py 94.91% <100.00%> (+0.04%) ⬆️
mmseg/models/backbones/vit.py 84.84% <100.00%> (ø)
mmseg/models/decode_heads/fpn_head.py 100.00% <100.00%> (ø)
mmseg/models/decode_heads/setr_mla_head.py 100.00% <100.00%> (ø)
mmseg/models/decode_heads/setr_up_head.py 100.00% <100.00%> (ø)
mmseg/models/necks/multilevel_neck.py 100.00% <100.00%> (ø)
mmseg/datasets/pipelines/transforms.py 97.98% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f800669...a2f96a6. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Hi @xiexinch
Please fix the lint error!

backend: PyTorch
batch size: 1
mode: FP32
resolution: (512x1024)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of resolution is (h, w)

configs/ann/ann.yml Outdated Show resolved Hide resolved
Copy link

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xvjiarui xvjiarui merged commit 52b4fa5 into open-mmlab:master Jul 31, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* init script

* update scripts and generate new yml

* fix lint: deeplabv3plus.yml

* modify resolution representation

* remove  field

* format crop_size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants