Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Ensure that items in dataset have the same order across multi machine #780

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

uni19
Copy link
Contributor

@uni19 uni19 commented Aug 12, 2021

Motivation

ensure items in dataset have the same order across multi machine

Modification

sort items according to their filenames when using scandir

@Junjun2016
Copy link
Collaborator

Hi @uni19
Could you please fix the lint error?

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #780 (c965947) into master (58f5dbc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c965947 differs from pull request most recent head f484482. Consider uploading reports for the commit f484482 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #780   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         107      107           
  Lines        5847     5848    +1     
  Branches      960      961    +1     
=======================================
+ Hits         4992     4993    +1     
  Misses        673      673           
  Partials      182      182           
Flag Coverage Δ
unittests 85.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/custom.py 89.88% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f5dbc...f484482. Read the comment docs.

@Junjun2016 Junjun2016 changed the title ensure items in dataset have the same order across multi machine [Fix] Ensure items in dataset have the same order across multi machine Aug 12, 2021
Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Junjun2016 Junjun2016 merged commit 99d8376 into open-mmlab:master Aug 19, 2021
@Junjun2016 Junjun2016 changed the title [Fix] Ensure items in dataset have the same order across multi machine [Fix] Ensure that items in dataset have the same order across multi machine Aug 19, 2021
459737087 pushed a commit to 459737087/mmsegmentation that referenced this pull request Aug 23, 2021
@uni19 uni19 deleted the fix_custom_dataset branch September 10, 2021 03:35
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* clean up resnet.py

* make style and quality

* minor formatting
@OpenMMLab-Coodinator
Copy link

Hi! @uni19 First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants