Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support eval concate dataset and add tool to show dataset #781

Closed
wants to merge 2 commits into from
Closed

[Feature] Support eval concate dataset and add tool to show dataset #781

wants to merge 2 commits into from

Conversation

FreyWang
Copy link
Contributor

@FreyWang FreyWang commented Aug 12, 2021 •
edited
Loading

Motivation

  1. The pr support eval concate dataset by add an option parameter to Dataset.eval()
  2. Add a script to show origin train set and augumented train set which is modified from mmdetection

Modification

  • Add file tools/browse_dataset.py
  • Add parameter gt_seg_maps=None in custom.py, Add evaluate() to ConcatDataset of dataset_wrappers.py

@FreyWang
[Feature] Support eval concate dataset
ac71f6b 
Signed-off-by: wangxionghui <wangxionghui.kk@bytedance.com>
@FreyWang
add tool to show train data and origin data
0562c02 
Signed-off-by: wangxionghui <wangxionghui.kk@bytedance.com>
@CLAassistant
Copy link

CLAassistant commented Aug 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 12, 2021 •
edited
Loading

Codecov Report

Merging #781 (2312ee7) into master (f6dca38) will decrease coverage by 0.35%.
The diff coverage is 21.87%.

❗ Current head 2312ee7 differs from pull request most recent head 0562c02. Consider uploading reports for the commit 0562c02 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   85.37%   85.02%   -0.36%     
==========================================
  Files         107      107              
  Lines        5859     5888      +29     
  Branches      962      970       +8     
==========================================
+ Hits         5002     5006       +4     
- Misses        672      695      +23     
- Partials      185      187       +2
Flag Coverage Δ
unittests 85.00% <21.87%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/dataset_wrappers.py 51.11% <15.38%> (-48.89%) ⬇️
mmseg/datasets/builder.py 87.34% <50.00%> (-2.14%) ⬇️
mmseg/datasets/custom.py 89.28% <50.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6dca38...0562c02. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Hi @FreyWang
Thanks for your contribution!

Junjun2016
Junjun2016 reviewed Aug 19, 2021
View reviewed changes
mmseg/datasets/dataset_wrappers.py
@@ -14,12 +15,67 @@ class ConcatDataset(_ConcatDataset):
datasets (list[:obj:`Dataset`]): A list of datasets.
"""

def __init__(self, datasets):
def __init__(self, datasets, separate_eval=True):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring for separate_eval.

Junjun2016
Junjun2016 reviewed Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide some numerical results for ConcatDataset with seperate_eval?

@Junjun2016
Copy link
Collaborator

Hi @FreyWang
Please also fix the conflict and merge the upstream master.

@Junjun2016 Junjun2016 changed the title support eval concate dataset and add tool to show dataset [Feature] Support eval concate dataset and add tool to show dataset Aug 19, 2021
@FreyWang
Copy link
Contributor Author

Hi @FreyWang
Please also fix the conflict and merge the upstream master.

ok, I will do it today

@Junjun2016
Copy link
Collaborator

Hi @FreyWang
Please also fix the conflict and merge the upstream master.

ok, I will do it today

Please also take a look at this PR #709.

@MengzhangLI
Copy link
Contributor

Hi, @FreyWang
Thanks for your great work.

Would you mind upgrade your PR, i.e., make feature of this PR could meet up the latest version of MMsegmentation? Thus we could merge this PR as soon as possible.

Best,

@FreyWang
Copy link
Contributor Author

Hi, @FreyWang
Thanks for your great work.

Would you mind upgrade your PR, i.e., make feature of this PR could meet up the latest version of MMsegmentation? Thus we could merge this PR as soon as possible.

Best,

sorry for late, I will try to upgrade it in this weekend as it's busy this week 😢

@FreyWang
Copy link
Contributor Author

Hi, @FreyWang
Thanks for your great work.

Would you mind upgrade your PR, i.e., make feature of this PR could meet up the latest version of MMsegmentation? Thus we could merge this PR as soon as possible.

Best,

HI, @MengzhangLI @Junjun2016 , new PR is submit in PR#833

@Junjun2016 Junjun2016 closed this Sep 3, 2021
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
@allo-
[textual_inversion] Add an option for only saving the embeddings (ope…
d1bcbf3 
…n-mmlab#781)

[textual_inversion] Add an option to only save embeddings

Add an command line option --only_save_embeds to the example script, for
not saving the full model. Then only the learned embeddings are saved,
which can be added to the original model at runtime in a similar way as
they are created in the training script.
Saving the full model is forced when --push_to_hub is used. (Implements open-mmlab#759)
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
@irvingzhang0512
[Improvement] Add softmax option for pytorch2onnx tool. (open-mmlab#781)
16c2c4f 
* first commit

* update docs

* add unittest

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junjun2016 Junjun2016 Junjun2016 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FreyWang @CLAassistant @Junjun2016 @MengzhangLI