[Fix] Fix random behavior of update_model_index in pre-commit hook #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 107 107
Lines 5859 5859
Branches 962 962
=======================================
Hits 5002 5002
Misses 672 672
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Hi @zhouzaida |
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
sibozhang
pushed a commit
to sibozhang/mmsegmentation
that referenced
this pull request
Mar 22, 2024
* resolve comments * update changelog * speed up readcsv * remove difficult & group flags * update action_thr * remove arg capacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The pre-commit hook update_model_index is observed to exit with code 1 (indicating files modified) randomly without actually modifying the metafiles. We found that this is caused by file I/O conflict when this pre-commit hook is running in a multi-threading manner.
Modification
require_serial=truein.pre-commit-config.yamlto prevent multi-threading that causes file I/O conflictupdate_model_indexinmd2yml.pyto prevent redundant file I/Osort_keys=Trueand update model.ymlfilesRelated PR open-mmlab/mmpose#866
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No.