Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support loading GT for evaluation from multi-file backend #867

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

uni19
Copy link
Contributor

@uni19 uni19 commented Sep 10, 2021

Motivation

support load gt for evaluation from multi file backend

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #867 (74a4ebc) into master (872e544) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   89.02%   89.05%   +0.03%     
==========================================
  Files         111      111              
  Lines        6043     6051       +8     
  Branches      969      969              
==========================================
+ Hits         5380     5389       +9     
  Misses        467      467              
+ Partials      196      195       -1     
Flag Coverage Δ
unittests 89.05% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/custom.py 92.43% <100.00%> (+0.34%) ⬆️
mmseg/datasets/pipelines/loading.py 98.52% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872e544...74a4ebc. Read the comment docs.

@Junjun2016 Junjun2016 changed the title support load gt for evaluation from multi file backend [Enhancement] Support load gt for evaluation from multi file backend Sep 10, 2021
@Junjun2016 Junjun2016 changed the title [Enhancement] Support load gt for evaluation from multi file backend [Enhancement] Support loading GT for evaluation from multi-file backend Sep 10, 2021
Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmseg/datasets/custom.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openmmlab-bot
Copy link
Collaborator

@xvjiarui xvjiarui merged commit 5a7996d into open-mmlab:master Sep 15, 2021
@xvjiarui
Copy link
Collaborator

@uni19 Thanks for your nice contribution!

@uni19 uni19 deleted the multi_file_backend_evaluation branch September 15, 2021 07:10
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
…nd (open-mmlab#867)

* support load gt for evaluation from multi-backend

* move some code from get_gt_seg_maps to get_one_gt_seg_map

* rename gt_seg_map_loader_conf to gt_seg_map_loader_cfg

* fix doc str

* rename get_one_gt_seg_map to get_gt_seg_map_by_idx
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* Fix pypi label in README.md

* fix README_CN.md
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
* resolve comments

* update changelog

* support mmcli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants