Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix accepting an unexpected argument local-rank in PyTorch 2.0 #728

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

fangyixiao18
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refer to open-mmlab/mmagic#1712

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.50 🎉

Comparison is base (105ca79) 80.24% compared to head (c2ba1ad) 80.75%.

❗ Current head c2ba1ad differs from pull request most recent head 47a0348. Consider uploading reports for the commit 47a0348 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #728      +/-   ##
===========================================
+ Coverage    80.24%   80.75%   +0.50%     
===========================================
  Files          141      144       +3     
  Lines         5129     5207      +78     
  Branches       687      693       +6     
===========================================
+ Hits          4116     4205      +89     
+ Misses         873      861      -12     
- Partials       140      141       +1     
Flag Coverage Δ
unittests 80.75% <100.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/datasets/transforms/__init__.py 100.00% <100.00%> (ø)
mmselfsup/datasets/transforms/pytorch_transform.py 100.00% <100.00%> (ø)
mmselfsup/models/algorithms/__init__.py 100.00% <100.00%> (ø)
mmselfsup/models/algorithms/pixmim.py 100.00% <100.00%> (ø)
mmselfsup/models/target_generators/__init__.py 100.00% <100.00%> (ø)
...sup/models/target_generators/low_freq_generator.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fangyixiao18 fangyixiao18 merged commit 6c5e836 into open-mmlab:dev-1.x Mar 28, 2023
@fangyixiao18 fangyixiao18 deleted the local-rank branch April 6, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants