Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support errors visualization for mot #212

Merged
merged 15 commits into from
Jul 26, 2021

Conversation

ToumaKazusa3
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #212 (751e522) into master (11d2a1c) will decrease coverage by 0.13%.
The diff coverage is 80.61%.

❗ Current head 751e522 differs from pull request most recent head 9962e72. Consider uploading reports for the commit 9962e72 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   69.64%   69.51%   -0.14%     
==========================================
  Files          87       87              
  Lines        4395     4491      +96     
  Branches      863      876      +13     
==========================================
+ Hits         3061     3122      +61     
- Misses       1047     1069      +22     
- Partials      287      300      +13     
Flag Coverage Δ
unittests 69.51% <80.61%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/models/sot/base.py 49.51% <42.85%> (-0.49%) ⬇️
mmtrack/core/utils/visualization.py 47.77% <83.14%> (+34.59%) ⬆️
mmtrack/core/utils/__init__.py 100.00% <100.00%> (ø)
mmtrack/models/reid/base_reid.py 75.00% <0.00%> (-10.00%) ⬇️
mmtrack/datasets/pipelines/transforms.py 85.00% <0.00%> (-3.13%) ⬇️
mmtrack/datasets/sot_train_dataset.py 80.80% <0.00%> (-2.03%) ⬇️
mmtrack/models/mot/trackers/base_tracker.py 82.94% <0.00%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d2a1c...9962e72. Read the comment docs.

tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
@GT9505
Copy link
Collaborator

GT9505 commented Jul 17, 2021

LGTM @OceanPang

tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualization.py Outdated Show resolved Hide resolved
@OceanPang
Copy link
Collaborator

Please re-organize the functions and re-check the grammar of English docs.

@ToumaKazusa3 ToumaKazusa3 changed the title [Feature] Support visualization for mot [Feature] Support errors visualization for mot Jul 19, 2021
mmtrack/core/utils/__init__.py Outdated Show resolved Hide resolved
mmtrack/core/utils/visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualize.py Outdated Show resolved Hide resolved
mmtrack/core/utils/visualization.py Outdated Show resolved Hide resolved
mmtrack/core/utils/visualization.py Show resolved Hide resolved
mmtrack/core/utils/visualization.py Outdated Show resolved Hide resolved
tools/mot_error_visualize.py Outdated Show resolved Hide resolved
tools/mot_error_visualize.py Outdated Show resolved Hide resolved
tools/mot_error_visualize.py Outdated Show resolved Hide resolved
@GT9505
Copy link
Collaborator

GT9505 commented Jul 22, 2021

please also add unittests for fuctions in visualization.py

@GT9505 GT9505 self-requested a review July 26, 2021 07:28
@GT9505 GT9505 merged commit 9fb7031 into open-mmlab:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants