Refactor the anchor in SiameseRPN++ #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 68.88% 68.35% -0.54%
==========================================
Files 87 87
Lines 4577 4563 -14
Branches 890 890
==========================================
- Hits 3153 3119 -34
- Misses 1140 1156 +16
- Partials 284 288 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
GT9505
reviewed
Aug 2, 2021
| all_anchors[:, 0] += -(feat_w // 2) * stride[0] | ||
| all_anchors[:, 1] += -(feat_h // 2) * stride[1] | ||
| all_anchors[:, 2] += -(feat_w // 2) * stride[0] | ||
| all_anchors[:, 3] += -(feat_h // 2) * stride[1] |
There was a problem hiding this comment.
we can simplify it by using slices.
all_anchors[:, 0:4:2] += -(feat_w // 2) * stride[0]
| all_anchors = base_anchors[:, None, :] + shifts[None, :, :] | ||
| all_anchors = all_anchors.view(-1, 4) | ||
|
|
||
| # transform the coordinate origin from the top left corner to the |
There was a problem hiding this comment.
Please capitalize the first letter. Please also fix the problem in other comments。
GT9505
reviewed
Aug 3, 2021
GT9505
reviewed
Aug 3, 2021
| # Transform the coordinate origin from the top left corner to the | ||
| # center in the scaled featurs map. | ||
| all_anchors[:, 0:4:2] += -(feat_w // 2) * stride_w | ||
| all_anchors[:, 1:4:2] += -(feat_h // 2) * stride_h |
There was a problem hiding this comment.
We can delete this function and move line 78-79 outside of the function, since the function is almost the same as function in mmdet
GT9505
reviewed
Aug 9, 2021
| self.anchors = self.anchor_generator.grid_priors([score_maps_size], | ||
| gt_bbox.device)[0] | ||
| # Transform the coordinate origin from the top left corner to the | ||
| # center in the scaled featurs map. |
| labels = gt_bbox.new_zeros((num_anchors, ), dtype=torch.long) | ||
| labels_weights = gt_bbox.new_zeros((num_anchors, ), dtype=torch.float) | ||
| bbox_weights = gt_bbox.new_zeros((num_anchors, ), dtype=torch.float) | ||
| bbox_targets = gt_bbox.new_zeros((num_anchors, ), dtype=torch.float) |
There was a problem hiding this comment.
bbox_targets = gt_bbox.new_zeros((num_anchors, 4)
|
The unittest failed. |
added 2 commits
August 17, 2021 21:37
GT9505
reviewed
Aug 18, 2021
GT9505
reviewed
Aug 20, 2021
| @@ -137,8 +137,8 @@ def __init__(self, | |||
| init_cfg=None, | |||
| *args, | |||
| **kwargs): | |||
| super(SiameseRPNHead, self).__init__(init_cfg) | |||
| self.anchor_generator = build_anchor_generator(anchor_generator) | |||
| super(SiameseRPNHead, self).__init__(*args, **kwargs) | |||
There was a problem hiding this comment.
We need to pass init_cfg into the super class.
And the super class can not take *args, **kwargs as inputs
| num_anchors = H * W * num_base_anchors | ||
| labels = gt_bbox.new_zeros((num_anchors, ), dtype=torch.long) | ||
| labels_weights = gt_bbox.new_zeros((num_anchors, )) | ||
| bbox_weights = gt_bbox.new_zeros((num_anchors, )) |
There was a problem hiding this comment.
bbox_weights = gt_bbox.new_zeros((num_anchors, 4))
| bbox_targets = bbox_targets.T.reshape(4, C, H, W) | ||
| bbox_weights = bbox_weights.reshape(C, H, W) | ||
| bbox_weights = bbox_weights[None].repeat(4, 1, 1, 1) | ||
| bbox_weights = bbox_weights.view(-1, 1).repeat(1, 4) |
| score_maps_size, cls_score.device)[0] | ||
| # Transform the coordinate origin from the top left corner to the | ||
| # center in the scaled featurs map. |
| labels = labels.reshape(C, H, W) | ||
| labels_weights = labels_weights.reshape(C, H, W) | ||
| bbox_weights = bbox_weights[None].repeat(4, 1, 1, 1) | ||
| bbox_weights = bbox_weights.view(-1, 1).repeat(1, 4) |
added 2 commits
August 20, 2021 11:43
GT9505
approved these changes
Aug 20, 2021
GT9505
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly refactors the anchor in SiameseRPN++ as follows :
[cx, cy, w, h]to[tl_x, tl_y, br_x, br_y].grid_anchorswithgrid_priorsto skip the deprecated warnings in MMDet.