Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify model initialization #235

Merged
merged 11 commits into from
Aug 10, 2021
Merged

Unify model initialization #235

merged 11 commits into from
Aug 10, 2021

Conversation

GT9505
Copy link
Collaborator

@GT9505 GT9505 commented Aug 10, 2021

Refactoring model initialization methods based MMCV. For more information, please refer to open-mmlab/mmcv#780 and open-mmlab/mmdet#4750

@GT9505 GT9505 changed the title Model init Unify model initialization Aug 10, 2021
@GT9505 GT9505 requested a review from OceanPang August 10, 2021 07:10
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #235 (9fb8ff3) into master (63db5ee) will decrease coverage by 1.06%.
The diff coverage is 46.36%.

❗ Current head 9fb8ff3 differs from pull request most recent head 4d89200. Consider uploading reports for the commit 4d89200 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   69.62%   68.56%   -1.07%     
==========================================
  Files          87       87              
  Lines        4563     4542      -21     
  Branches      887      885       -2     
==========================================
- Hits         3177     3114      -63     
- Misses       1091     1146      +55     
+ Partials      295      282      -13     
Flag Coverage Δ
unittests 68.53% <46.36%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/apis/inference.py 12.37% <0.00%> (-0.13%) ⬇️
mmtrack/models/reid/base_reid.py 86.95% <ø> (-1.05%) ⬇️
mmtrack/models/mot/deep_sort.py 50.87% <14.28%> (-9.51%) ⬇️
mmtrack/models/mot/tracktor.py 57.35% <14.28%> (-8.28%) ⬇️
mmtrack/models/vid/dff.py 63.04% <16.66%> (-5.85%) ⬇️
mmtrack/models/vid/fgfa.py 61.90% <16.66%> (-4.23%) ⬇️
mmtrack/models/vid/selsa.py 66.03% <25.00%> (-1.56%) ⬇️
mmtrack/models/sot/siamrpn.py 81.42% <27.27%> (-7.63%) ⬇️
mmtrack/models/aggregators/embed_aggregator.py 100.00% <100.00%> (ø)
mmtrack/models/aggregators/selsa_aggregator.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63db5ee...4d89200. Read the comment docs.

@OceanPang OceanPang merged commit ba2ef3c into open-mmlab:master Aug 10, 2021
@GT9505 GT9505 deleted the model_init branch August 11, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants