Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix several bugs in reid #249

Merged
merged 21 commits into from
Sep 2, 2021
Merged

Conversation

ToumaKazusa3
Copy link
Contributor

@ToumaKazusa3 ToumaKazusa3 commented Aug 25, 2021

This PR fixes several bugs in reid:

  1. reid model can not be tested.
  2. the tools/convert_dataset/mot2reid.py script may generate different train_80.txt and val_20.txt in different machines.

@ToumaKazusa3 ToumaKazusa3 changed the title Fix reid test [Fix] fix reid test Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #249 (872b58c) into master (8016b90) will decrease coverage by 0.15%.
The diff coverage is 78.94%.

❗ Current head 872b58c differs from pull request most recent head 9841526. Consider uploading reports for the commit 9841526 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   68.95%   68.79%   -0.16%     
==========================================
  Files          90       90              
  Lines        4641     4650       +9     
  Branches      896      897       +1     
==========================================
- Hits         3200     3199       -1     
- Misses       1154     1161       +7     
- Partials      287      290       +3     
Flag Coverage Δ
unittests 68.79% <78.94%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/datasets/reid_dataset.py 86.23% <50.00%> (-1.62%) ⬇️
mmtrack/models/mot/trackers/tracktor_tracker.py 64.04% <66.66%> (+0.09%) ⬆️
mmtrack/models/mot/trackers/sort_tracker.py 75.23% <100.00%> (+0.48%) ⬆️
mmtrack/models/reid/base_reid.py 88.00% <100.00%> (+1.04%) ⬆️
mmtrack/datasets/sot_train_dataset.py 78.78% <0.00%> (-7.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8016b90...9841526. Read the comment docs.

mmtrack/models/mot/trackers/sort_tracker.py Outdated Show resolved Hide resolved
mmtrack/models/mot/trackers/tracktor_tracker.py Outdated Show resolved Hide resolved
mmtrack/models/reid/base_reid.py Outdated Show resolved Hide resolved
tools/test.py Outdated Show resolved Hide resolved
tools/train.py Outdated Show resolved Hide resolved
tools/test.py Outdated Show resolved Hide resolved
mmtrack/datasets/reid_dataset.py Outdated Show resolved Hide resolved
tests/test_data/test_datasets/test_reid_dataset.py Outdated Show resolved Hide resolved
@GT9505 GT9505 changed the title [Fix] fix reid test [Fix] fix serveral bugs in reid Sep 2, 2021
@GT9505 GT9505 changed the title [Fix] fix serveral bugs in reid [Fix] fix several bugs in reid Sep 2, 2021
@GT9505 GT9505 merged commit 9e5c804 into open-mmlab:master Sep 2, 2021
@GT9505 GT9505 mentioned this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants