-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Refactor VOT, UAV123, OTB100 and LaSOT dataset class based on BaseSOTDataset #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint error firstly
My local pre-commit doesn't report this lint error, so werid! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will be reviewed after PR #402 is merged
We can continue on this PR now. |
Please fix the CI before next review. |
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 70.37% 70.91% +0.53%
==========================================
Files 116 116
Lines 6113 6226 +113
Branches 1181 1192 +11
==========================================
+ Hits 4302 4415 +113
Misses 1453 1453
Partials 358 358
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test the performance of SiameseRPN++ on VOT, UAV123, OTB100 and LaSOT after completing the reviewing comments. Then, we can merge this PR.
Refactor VOT2018Dataset, UAV123Dataset, OTB100Dataset and LaSOTDataset based on BaseSOTDataset.
Please refer to #393 for more details.