Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Refactor VOT, UAV123, OTB100 and LaSOT dataset class based on BaseSOTDataset #401

Merged
merged 18 commits into from
Jan 29, 2022

Conversation

JingweiZhang12
Copy link
Collaborator

@JingweiZhang12 JingweiZhang12 commented Jan 21, 2022

Refactor VOT2018Dataset, UAV123Dataset, OTB100Dataset and LaSOTDataset based on BaseSOTDataset.
Please refer to #393 for more details.

Copy link
Collaborator

@GT9505 GT9505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint error firstly

@JingweiZhang12
Copy link
Collaborator Author

My local pre-commit doesn't report this lint error, so werid!

Copy link
Collaborator

@GT9505 GT9505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be reviewed after PR #402 is merged

@GT9505
Copy link
Collaborator

GT9505 commented Jan 25, 2022

This PR will be reviewed after PR #402 is merged

We can continue on this PR now.

mmtrack/core/evaluation/eval_sot_ope.py Outdated Show resolved Hide resolved
mmtrack/core/evaluation/eval_sot_vot.py Outdated Show resolved Hide resolved
mmtrack/datasets/base_sot_dataset.py Show resolved Hide resolved
mmtrack/datasets/otb_dataset.py Show resolved Hide resolved
mmtrack/datasets/vot_dataset.py Outdated Show resolved Hide resolved
mmtrack/datasets/vot_dataset.py Show resolved Hide resolved
mmtrack/datasets/vot_dataset.py Outdated Show resolved Hide resolved
@GT9505
Copy link
Collaborator

GT9505 commented Jan 26, 2022

Please fix the CI before next review.

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #401 (27f56a5) into master (142922e) will increase coverage by 0.53%.
The diff coverage is 86.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   70.37%   70.91%   +0.53%     
==========================================
  Files         116      116              
  Lines        6113     6226     +113     
  Branches     1181     1192      +11     
==========================================
+ Hits         4302     4415     +113     
  Misses       1453     1453              
  Partials      358      358              
Flag Coverage Δ
unittests 70.81% <86.12%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/apis/train.py 16.66% <0.00%> (ø)
mmtrack/datasets/otb_dataset.py 65.11% <64.28%> (-34.89%) ⬇️
mmtrack/core/evaluation/eval_sot_ope.py 97.87% <85.71%> (+6.38%) ⬆️
mmtrack/datasets/vot_dataset.py 85.22% <88.23%> (-3.67%) ⬇️
mmtrack/datasets/base_sot_dataset.py 86.25% <90.90%> (+24.65%) ⬆️
mmtrack/core/evaluation/eval_sot_vot.py 86.23% <100.00%> (-0.25%) ⬇️
mmtrack/datasets/lasot_dataset.py 100.00% <100.00%> (ø)
mmtrack/datasets/uav123_dataset.py 100.00% <100.00%> (ø)
mmtrack/datasets/sot_test_dataset.py 23.91% <0.00%> (-54.35%) ⬇️
mmtrack/models/reid/base_reid.py 78.26% <0.00%> (-8.70%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142922e...27f56a5. Read the comment docs.

Copy link
Collaborator

@GT9505 GT9505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the performance of SiameseRPN++ on VOT, UAV123, OTB100 and LaSOT after completing the reviewing comments. Then, we can merge this PR.

mmtrack/datasets/vot_dataset.py Outdated Show resolved Hide resolved
@GT9505 GT9505 merged commit 5242826 into open-mmlab:master Jan 29, 2022
@JingweiZhang12 JingweiZhang12 deleted the vou_dataset branch April 29, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants