[Feature] Add 6 data pipelines used in STARK method #426
Conversation
|
Maybe we can include the original 'ConcatVideoReferences' function into the new 'ConcatVideo2TwoParts' function? |
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 70.89% 71.33% +0.44%
==========================================
Files 117 117
Lines 6249 6534 +285
Branches 1198 1250 +52
==========================================
+ Hits 4430 4661 +231
- Misses 1460 1488 +28
- Partials 359 385 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Souds well. But We still need to keep the interface of |
JingweiZhang12
force-pushed
the
stark_pipeline
branch
from
a038d9b
to
09bb700
Compare
| outs = [] | ||
| for i, _results in enumerate(results): | ||
| image = _results['img'] | ||
| gt_bbox = _results[_results.get('bbox_fields', [])[0]][0] |
There was a problem hiding this comment.
can we change all _results.get('bbox_fields', [])[0] to 'gt_bboxes'?
There was a problem hiding this comment.
I think it's no problem. I do this mainly refer to SeqCropLikeSiamFC though I don't know why.
There was a problem hiding this comment.
Then please also change the codes in SeqCropLikeSiamFC
| _results['img_shape'] = crop_img.shape | ||
| _results[_results.get('bbox_fields', [])[0]] = generated_bbox | ||
| _results['seg_fields'] = ['att_mask'] | ||
| _results[_results.get('seg_fields', [])[0]] = att_mask |
There was a problem hiding this comment.
Do not use _results.get('seg_fields', [])[0] to get the mask.
The xxx_field is used for preprocessing some variables with the same type, do not use hard code [0] to get the specific variable.
You should use _results['att_mask'] = att_mask to record the mask
There was a problem hiding this comment.
I do this mainly because the mask also need to be cropped in SeqRandomFlip to keep the same offset
as image cropping.
In our codebase, this operation is applicable only when adding 'mask' into 'seg_fields'.
There was a problem hiding this comment.
Then please use _results['att_mask'] = att_mask to record the mask
GT9505
changed the title
We add 6 data pipelines used in STARK method as the following: