Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support the testing of QDTrack algorithm in MOT #451

Merged
merged 17 commits into from
Mar 8, 2022
Merged

[Feature] Support the testing of QDTrack algorithm in MOT #451

merged 17 commits into from
Mar 8, 2022

Conversation

Seerkfang
Copy link
Collaborator

No description provided.

@Seerkfang Seerkfang requested a review from GT9505 March 6, 2022 12:54
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #451 (2b6d16a) into master (8143901) will increase coverage by 0.55%.
The diff coverage is 78.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   72.99%   73.54%   +0.55%     
==========================================
  Files         125      126       +1     
  Lines        7216     7375     +159     
  Branches     1364     1390      +26     
==========================================
+ Hits         5267     5424     +157     
- Misses       1519     1528       +9     
+ Partials      430      423       -7     
Flag Coverage Δ
unittests 73.45% <78.61%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...track/models/trackers/quasi_dense_embed_tracker.py 75.88% <75.88%> (ø)
mmtrack/models/mot/qdtrack.py 87.23% <100.00%> (+12.23%) ⬆️
mmtrack/models/trackers/__init__.py 100.00% <100.00%> (ø)
mmtrack/datasets/base_sot_dataset.py 86.76% <0.00%> (+0.09%) ⬆️
mmtrack/datasets/dataset_wrappers.py 86.95% <0.00%> (+0.59%) ⬆️
mmtrack/models/mot/base.py 53.46% <0.00%> (+0.99%) ⬆️
mmtrack/models/track_heads/stark_head.py 97.45% <0.00%> (+1.27%) ⬆️
mmtrack/models/trackers/base_tracker.py 86.25% <0.00%> (+1.52%) ⬆️
mmtrack/datasets/sot_train_dataset.py 81.81% <0.00%> (+2.02%) ⬆️
mmtrack/datasets/pipelines/transforms.py 89.44% <0.00%> (+2.52%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8143901...2b6d16a. Read the comment docs.

mmtrack/models/mot/qdtrack.py Show resolved Hide resolved
mmtrack/models/mot/qdtrack.py Outdated Show resolved Hide resolved
mmtrack/models/mot/qdtrack.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/quasi_dense_embed_tracker.py Outdated Show resolved Hide resolved
@Seerkfang Seerkfang requested a review from GT9505 March 7, 2022 07:53
@@ -9,7 +9,7 @@
norm_cfg=dict(requires_grad=False),
style='caffe',
init_cfg=dict(
type='Pretrained', checkpoint='torchvision://resnet101')),
type='Pretrained', checkpoint='torchvision://resnet50')),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to load the pretrain weights of coco?

mmtrack/models/mot/qdtrack.py Outdated Show resolved Hide resolved
mmtrack/models/mot/qdtrack.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/quasi_dense_embed_tracker.py Outdated Show resolved Hide resolved
mmtrack/models/trackers/quasi_dense_embed_tracker.py Outdated Show resolved Hide resolved
@@ -0,0 +1,263 @@
# Copyright (c) OpenMMLab. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codes in this file are hard to understand.
Suggest to add many comments to explain the motivation.

@Seerkfang Seerkfang requested a review from GT9505 March 7, 2022 10:25
@GT9505
Copy link
Collaborator

GT9505 commented Mar 7, 2022

The PR can be merged after adding more comments in the code

@Seerkfang Seerkfang requested a review from GT9505 March 7, 2022 13:06
Copy link
Collaborator

@GT9505 GT9505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the lint error

@GT9505 GT9505 merged commit d005f03 into open-mmlab:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants