-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Support empty tensor for selsa_aggregator #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Chop1, thanks for your contribution :)
Could you please update the PR based on the comments?
Then, We can merge this PR.
Co-authored-by: Tao Gong <gt950513@mail.ustc.edu.cn>
bug in passed dimension Co-authored-by: Tao Gong <gt950513@mail.ustc.edu.cn>
|
||
x_embed = self.fc_embed(x) | ||
# [num_attention_blocks, roi_n, C / num_attention_blocks] | ||
x_embed = x_embed.view(roi_n, self.num_attention_blocks, | ||
-1).permute(1, 0, 2) | ||
num_C_per_attention_block).permute(1, 0, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All num_C_per_attention_block
should be renamed to num_c_per_att_block
By the way, it is better to git commit in your local machine firstly. Then push it to the PR. The reason is that using commit suggestion
may cause lint error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the dedication and explanation.
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 73.04% 73.38% +0.33%
==========================================
Files 126 126
Lines 7338 7378 +40
Branches 1390 1390
==========================================
+ Hits 5360 5414 +54
+ Misses 1550 1540 -10
+ Partials 428 424 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @Chop1!First of all, we want to express our gratitude for your significant PR in the MMTracking project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
see #370
see #375
(sorry for the double pr)