Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Support training siamrpn++ based on BaseSOTDataset instead of SOTTrainDataset #496

Merged
merged 40 commits into from
Apr 23, 2022

Conversation

JingweiZhang12
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #496 (c62bf4c) into master (4ecd365) will decrease coverage by 0.36%.
The diff coverage is 49.12%.

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   73.58%   73.22%   -0.37%     
==========================================
  Files         126      126              
  Lines        7370     7424      +54     
  Branches     1380     1393      +13     
==========================================
+ Hits         5423     5436      +13     
- Misses       1526     1560      +34     
- Partials      421      428       +7     
Flag Coverage Δ
unittests 73.16% <49.12%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/core/evaluation/eval_sot_vot.py 86.23% <ø> (ø)
mmtrack/datasets/builder.py 28.57% <0.00%> (-4.77%) ⬇️
mmtrack/datasets/tao_dataset.py 83.95% <ø> (ø)
mmtrack/datasets/pipelines/processing.py 67.87% <55.10%> (-12.30%) ⬇️
mmtrack/datasets/pipelines/__init__.py 100.00% <100.00%> (ø)
mmtrack/models/reid/base_reid.py 78.26% <0.00%> (-8.70%) ⬇️
mmtrack/datasets/sot_train_dataset.py 81.81% <0.00%> (-4.05%) ⬇️
mmtrack/models/trackers/base_tracker.py 84.73% <0.00%> (-1.53%) ⬇️
mmtrack/models/sot/siamrpn.py 81.56% <0.00%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ecd365...c62bf4c. Read the comment docs.

@JingweiZhang12
Copy link
Collaborator Author

JingweiZhang12 commented Apr 15, 2022

The training iterations in this code are about 3 times larger than that of original code in every epoch. Werid.
I'll check it later.
You can review the others about this PR.

mmtrack/datasets/pipelines/processing.py Show resolved Hide resolved
mmtrack/datasets/builder.py Outdated Show resolved Hide resolved
mmtrack/datasets/builder.py Outdated Show resolved Hide resolved
@JingweiZhang12
Copy link
Collaborator Author

This PR can be reviewed and merged. The docs about newly released models will be updated in the next PR.

configs/sot/siamese_rpn/siamese_rpn_r50_20e_lasot.py Outdated Show resolved Hide resolved
@@ -10,6 +10,11 @@

data_root = 'data/'
train_pipeline = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The train_pipeleine can be inherit from base config?

Copy link
Collaborator Author

@JingweiZhang12 JingweiZhang12 Apr 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The train_pipeline of OTB adds a SeqGrayAug, which can't inherit from the base config.

dict(type='SeqDefaultFormatBundle', ref_prefix='search')
]
# dataset settings
data = dict(
samples_per_gpu=16,
train=[
train=dict(dataset_cfgs=[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key of train in data can be inherit from base config?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the train_pipeline is different, the dataset_cfgs list can not inherit from the base conifg.

@GT9505 GT9505 merged commit 8c309fe into open-mmlab:master Apr 23, 2022
@JingweiZhang12 JingweiZhang12 deleted the refactor_siamrpn branch October 13, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants