Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Support loading data from ceph for mot_challenge_dataset. #517

Merged
merged 6 commits into from
Apr 25, 2022
Merged

[Add] Support loading data from ceph for mot_challenge_dataset. #517

merged 6 commits into from
Apr 25, 2022

Conversation

pixeli99
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #517 (56d88d5) into master (12634be) will decrease coverage by 0.14%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   73.17%   73.02%   -0.15%     
==========================================
  Files         126      126              
  Lines        7370     7441      +71     
  Branches     1380     1395      +15     
==========================================
+ Hits         5393     5434      +41     
- Misses       1554     1572      +18     
- Partials      423      435      +12     
Flag Coverage Δ
unittests 72.98% <77.27%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/datasets/mot_challenge_dataset.py 73.70% <77.27%> (+0.21%) ⬆️
mmtrack/models/reid/base_reid.py 78.26% <0.00%> (-8.70%) ⬇️
mmtrack/datasets/builder.py 28.57% <0.00%> (-4.77%) ⬇️
mmtrack/models/sot/siamrpn.py 79.88% <0.00%> (-1.68%) ⬇️
mmtrack/models/trackers/base_tracker.py 84.73% <0.00%> (-1.53%) ⬇️
mmtrack/datasets/pipelines/transforms.py 87.15% <0.00%> (-0.92%) ⬇️
mmtrack/datasets/sot_train_dataset.py 79.79% <0.00%> (+1.01%) ⬆️
mmtrack/datasets/pipelines/processing.py 76.36% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12634be...56d88d5. Read the comment docs.

@pixeli99 pixeli99 changed the title [WIP] Support loading data from ceph for mot_challenge_dataset. [Add] Support loading data from ceph for mot_challenge_dataset. Apr 23, 2022
@pixeli99 pixeli99 requested a review from GT9505 April 23, 2022 04:21
mmtrack/datasets/mot_challenge_dataset.py Outdated Show resolved Hide resolved
mmtrack/datasets/mot_challenge_dataset.py Outdated Show resolved Hide resolved
mmtrack/datasets/mot_challenge_dataset.py Outdated Show resolved Hide resolved
mmtrack/datasets/mot_challenge_dataset.py Outdated Show resolved Hide resolved
@pixeli99 pixeli99 requested a review from GT9505 April 24, 2022 03:09
mmtrack/datasets/mot_challenge_dataset.py Show resolved Hide resolved
mmtrack/datasets/mot_challenge_dataset.py Outdated Show resolved Hide resolved
f.write(gt_content)
f.close()
# copy sequence file from ceph to local temporary directory
seqinfo_path = osp.join(local_dir.name, name, 'seqinfo.ini')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The seqinfo.ini may not exist.
Therefore, we need to copy seqinfo.ini only when it exist.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this file maybe necessary, because it will be used again on line 442.
dataset = [trackeval.datasets.MotChallenge2DBox(dataset_config)]
If we don't throw errors here, we will still throw errors later.

@pixeli99 pixeli99 requested a review from GT9505 April 24, 2022 14:41
Copy link
Collaborator

@GT9505 GT9505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this pr after making sure that we support loading data from both ceph and local disk.

@pixeli99 pixeli99 requested a review from GT9505 April 25, 2022 03:25
@pixeli99
Copy link
Collaborator Author

pixeli99 commented Apr 25, 2022

We can merge this pr after making sure that we support loading data from both ceph and local disk.

The test is successful on MOT16 and MOT17, using the faster rcnn model.

@GT9505 GT9505 merged commit 55ca8d9 into open-mmlab:master Apr 25, 2022
@pixeli99 pixeli99 deleted the petrel_mot branch June 21, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants