Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils man pages depend on executables #4

Closed
ompiteam opened this issue Sep 12, 2014 · 4 comments
Closed

utils man pages depend on executables #4

ompiteam opened this issue Sep 12, 2014 · 4 comments
Assignees
Labels
Milestone

Comments

@ompiteam
Copy link
Contributor

As mentioned in http://www.open-mpi.org/community/lists/hwloc-devel/2009/09/0060.php, there's a causality issue in "make dist": the man pages depend on the executables (because the man pages are generated via help2man).

This causes a problem with the following (e.g., nightly tarball generation):

{{{
svn co ...
cd ...
./autogen.sh
./configure
make dist
}}}

because the executables will try to build, but fail when there is no libhwloc.la.

A workaround, of course, is to "make all" first and then "make dist". But this is somewhat icky; it would be nice to have a better solution.

@ompiteam ompiteam added this to the v0.9.1 milestone Sep 12, 2014
@ompiteam ompiteam added the bug label Sep 12, 2014
@ompiteam
Copy link
Contributor Author

Imported from trac issue 3. Created by jsquyres on 2009-09-21T09:51:10, last modified: 2009-09-25T11:44:09

@ompiteam
Copy link
Contributor Author

Trac comment by bgoglin on 2009-09-25 02:03:16:

Is "writing manpages manually" considered a better solution ? Given that these utils have few command-line options, the manpages won't be very hard to write/maintain manually.

By the way, currently we get the "lt-" prefix in the toolname in the auto-generated manpages. We'll have to fix this if we keep using help2man.

@ompiteam
Copy link
Contributor Author

Trac comment by jsquyres on 2009-09-25 09:43:45:

Yes, it certainly would. Tell you what, I'll generate them with help2man and then commit the final pages. Then we'll just manually update from there.

@ompiteam
Copy link
Contributor Author

Trac comment by jsquyres on 2009-09-25 11:44:09:

(In [1001]) Fixes #3.

Have fixed versions of the man pages for the executables in svn under
the .1in filename pattern. These files are processed during "make
all" to make the corresponding .1 files. The changes that are added
in are the project name, date, and release version. This gives
nice/proper headers and footers on the man pages that are specific to
the version that they came from.

This also fixes the issue of having the man pages depend on the
executables, which was causing problems for making nightly tarballs.

bgoglin referenced this issue in bgoglin/hwloc Mar 16, 2018
On a 4-core machine with #2 offline, we want x86 to look at all 4 cores,
so that we get info for all online ones (#1, #3 and #4).
Before this commit, x86 would only look at the 3 first ones
(just like if the offline PUs were always at the end of the range).

At least Linux and Solaris can put some CPUs offline in the middle of the index range.
So ask hwloc_fallback_nbprocessors() to get the number of existing CPUs.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants