Skip to content
This repository has been archived by the owner on Sep 30, 2022. It is now read-only.

btl/openib: enable connecting processes from different subnets. #1043

Merged

Conversation

alinask
Copy link
Member

@alinask alinask commented Mar 23, 2016

  • Added an mca parameter to allow connecting processes from different
    subnets. Its current default value is 'false' - don't allow, to keep the
    current flow the way it is now.
  • rmdacm: when calling ibv_query_gid, use the gid index from
    btl_openib_gid_index.

from commit open-mpi/ompi@bbcbe3c in the master branch.

+ Added an mca parameter to allow connecting processes from different
subnets. Its current default value is 'false' - don't allow, to keep the
current flow the way it is now.

+ rmdacm: when calling ibv_query_gid, use the gid index from
btl_openib_gid_index.

from commit bbcbe3c in the master branch.
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1466/ for details.

@hppritcha
Copy link
Member

@alinask please assign a reviewer and milestone

@alinask
Copy link
Member Author

alinask commented Mar 23, 2016

@hppritcha I don't have permissions to set a milestone..

@jsquyres
Copy link
Member

@alinask Yeah, it's because of weirdness on Github -- they don't give us fine-grained enough permissions. As a workaround to let devs assign milestones/reviewers, we have the "ompi-bot" who can do these things for you -- see https://github.com/open-mpi/ompi/wiki/OmpiReleaseBotCommands.

@jsquyres
Copy link
Member

@alinask Also, Github pro tip: the bbcbe3c commit isn't known in this repository (because it's on the ompi master, not any of the release branches). So Github doesn't auto-link that commit hash in your description (or comment). But if you prefix that hash with the full repo name, Github will auto-link it.

For example: open-mpi/ompi@bbcbe3c.

This tells Github that that hash is part of the "ompi" git repo in the "open-mpi" org, and therefore it knows how to auto-link it to the original commit.

Make sense?

@alinask
Copy link
Member Author

alinask commented Mar 23, 2016

@jsquyres Thanks! I updated the commit message.

@jladd-mlnx
Copy link
Member

bot:milestone:v2.0.0

@ompiteam-bot ompiteam-bot added this to the v2.0.0 milestone Mar 23, 2016
@hppritcha hppritcha added the bug label Mar 23, 2016
@jladd-mlnx
Copy link
Member

@hppritcha this was already reviewed by @miked-mellanox.

Cherry-picked from open-mpi/ompi@bbcbe3c

@hppritcha
Copy link
Member

marking reviewed per earlier @miked-mellanox review on ompi/master

@mike-dubman
Copy link
Member

👍

@ompiteam-bot
Copy link

OMPIBot error: Label "reviewed" is already set on issue 1043.

@jladd-mlnx
Copy link
Member

@rhc54 Please merge. Thanks.

@jladd-mlnx
Copy link
Member

I'm sorry, this is for 2.0.0 - @jsquyres or @hppritcha please merge.

@jsquyres jsquyres modified the milestones: v2.1.0, v2.0.0 Mar 24, 2016
@hppritcha hppritcha modified the milestones: v2.0.0, v2.1.0 Apr 12, 2016
@hppritcha
Copy link
Member

@jsquyres should we try to get this in to 2.0.0?

@hppritcha
Copy link
Member

After some more consideration, I'm reluctant now to accept this in to 2.0.0 at this point. It is really more of a feature than a bug fix. At this point, if a customer needs to use this feature, they can make use of the 1.10.3 release. So I'm scheduling this for the 2.1 feature update.

@artpol84
Copy link
Contributor

artpol84 commented Aug 7, 2016

bot:mellanox:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2054/ for details.

@jsquyres jsquyres merged commit f1b9a5d into open-mpi:v2.x Sep 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants