Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Topic/v2.x/pmpi vs mpi #669

Merged
merged 12 commits into from
Dec 14, 2015
Merged

Conversation

ggouaillardet
Copy link
Contributor

  • remove the --disable-mpi-profile option
  • invoke PMPI_* C functions from Fortran bindings and oshmem

@ggouaillardet
Copy link
Contributor Author

:bot:assign: @jsquyres
:bot:milestone:v2.0.0
:bot🏷️rfc
:bot🏷️enhancement

@ompiteam-bot
Copy link

OMPIBot error: Label "rfc" does not exist.

@ggouaillardet
Copy link
Contributor Author

@jsquyres note this PR has been rebased from #667 which has not yet been merged

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/846/ for details.

@hppritcha
Copy link
Member

@ggouaillardet please rebase

@jsquyres
Copy link
Member

@ggouaillardet Can you provide a good title and description so that we know what this PR is? It's not clear what it's supposed to be, because it's got commits for MPI_Aint, mpi_f08 stuff, ...etc.

@jsquyres
Copy link
Member

@ggouaillardet Oh, I see -- I missed your comment about this being rebased from #667. But can you still fill in a title / description, anyway? Thanks!

@ggouaillardet ggouaillardet force-pushed the topic/v2.x/pmpi_vs_mpi branch from feb913f to c7f312e Compare October 20, 2015 00:04
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/874/ for details.

@ggouaillardet
Copy link
Contributor Author

@jsquyres i rebased (again) and added a description

@ggouaillardet ggouaillardet force-pushed the topic/v2.x/pmpi_vs_mpi branch from c7f312e to 23508fe Compare October 28, 2015 01:36
@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/938/ for details.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/971/ for details.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1007/ for details.

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1049/ for details.

@ggouaillardet
Copy link
Contributor Author

:bot:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1084/ for details.

ggouaillardet and others added 8 commits December 7, 2015 10:19
…ones

when profiling is built.
This prevents Fortran subroutines from being wrapped twice by third
party tools (e.g. once in Fortran and once in C)
see discussion starting at http://www.open-mpi.org/community/lists/devel/2015/08/17842.php

(back-ported from commit open-mpi/ompi@16d65a2)
this is a revamp of commit open-mpi/ompi@2d1a8fa
Thanks Jeff for the review !

(cherry picked from commit open-mpi/ompi@d7e6daf)
Add a little more to the verbose messages from d7e6daf.

(cherry picked from commit open-mpi/ompi@eeddb7a)
and directly call the PMPI_* symbols from C and Fortran bindings

(back-ported from commit open-mpi/ompi@291a464)
@ggouaillardet ggouaillardet force-pushed the topic/v2.x/pmpi_vs_mpi branch from 564f3c0 to d871301 Compare December 7, 2015 01:43
Thanks Jeff for the review

(cherry picked from commit open-mpi/ompi@ef03bc7)
Thanks Jeff for the review

(cherry picked from commit open-mpi/ompi@bfe8e03)
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1103/ for details.

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1099/ for details.

@jsquyres
Copy link
Member

@ggouaillardet A quick look through here indicates to me that I think you made all the changes I requested. Thanks!

@jsquyres
Copy link
Member

👍

@jsquyres
Copy link
Member

@hppritcha I think this is good to go.

hppritcha added a commit that referenced this pull request Dec 14, 2015
@hppritcha hppritcha merged commit 843b6b1 into open-mpi:v2.x Dec 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants