This repository was archived by the owner on Sep 30, 2022. It is now read-only.
v2.0.0: init finalize mutex plus mutex static initializer #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit open-mpi/ompi@039c7db)
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit open-mpi/ompi@7f7ff8d)
- If MPI_INITLIZED is invoked and MPI is only partially initialized, wait until MPI is fully initialized before returning. - If MPI_FINALIZED is invoked and MPI is only partially finalized, wait until MPI is fully finalized before returning. (cherry picked from commit open-mpi/ompi@f5ad90c)
Update language surrounding initialization and finalization in MPI_Init[_thread], MPI_Initialized, MPI_Finalize, and MPI_Finalized. (cherry picked from commit open-mpi/ompi@338257a)
(cherry picked from commit open-mpi/ompi@40b4d5d)
|
There are few other static mutexes in the code initialized to {{0}}. Do we want to change them to OPAL_MUTEX_STATIC_INIT ? |
|
Test PASSed. |
|
@bosilca Yes, we probably should. Especially since {{0}} is equivalent to not specifying an initializer at all. I will take a look and PR that change separately. 👍 |
|
@hppritcha Good to go. |
hppritcha
added a commit
that referenced
this pull request
Oct 16, 2015
…us-mutex-static-initializer v2.0.0: init finalize mutex plus mutex static initializer
jsquyres
deleted the
pr/2.0.0/init-finalize-mutex-plus-mutex-static-initializer
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring over @hjelmn's static mutex initializer and the MPI_INITIALIZED / MPI_FINALIZED updates for MPI-3.1.
Master commit IDs are in the commit messages. See open-mpi/ompi#1026 (static mutex initializer) and open-mpi/ompi#1007 (INITIALIZED / FINALIZED updates).
@hjelmn @bosilca Please review.