This repository has been archived by the owner on Sep 30, 2022. It is now read-only.
btl/sm: fix race condition #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
:bot:assign: @bosilca |
|
Are you certain we know it's content has been written before we close the file ? |
|
@bosilca I will fix this today and update the pr |
write to file and then rename, so when the file is open for read, its content is known to have been written. Fixes open-mpi/ompi#1230 (cherry picked from commit open-mpi/ompi@db4f483)
Thanks George for spotting this. (cherry picked from commit open-mpi/ompi@607d7c7)
ggouaillardet
force-pushed
the
topic/v2.x/sm_write_and_rename
branch
from
10fef2b to
70896ec
Compare
|
Test PASSed. |
|
@bosilca PR for v2.x has been updated, can you please review it ? |
|
@bosilca Can you review this PR? Thanks. |
|
👍 |
jsquyres
added a commit
that referenced
this pull request
Jan 4, 2016
…name btl/sm: fix race condition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write to file and then rename, so when the file is open for read, its content is known to have been written.
Fixes open-mpi/ompi#1230
(cherry picked from commit open-mpi/ompi@db4f483)