Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Adding support for dynamic endpoint creation #891

Merged
merged 3 commits into from
Jan 15, 2016
Merged

Adding support for dynamic endpoint creation #891

merged 3 commits into from
Jan 15, 2016

Conversation

jladd-mlnx
Copy link
Member

@jladd-mlnx
Adding support for dynamic endpoint creation
0b12f83 
Signed-off-by: Tomislav Janjusic <tomislavj@mngx-apl-01.mtl.labs.mlnx>
Signed-off-by: Tomislavj Janjusic <tomislavj@mellanox.com>
Signed-off-by: Joshua Ladd <jladd.mlnx@gmail.com>
@jladd-mlnx
Copy link
Member Author

@yosefe @alex-mikheev @miked-mellanox

Please review

@rhc54
Copy link

rhc54 commented Jan 12, 2016

hey guys - just curious. you have been among the most adamant about everything coming into OMPI via a PR, yet this code went directly into master. may one ask why?

@jladd-mlnx
Copy link
Member Author

@rhc54 My bad 🙈 , was too focused on my 🍒-picking and #️⃣ referencing.

@rhc54
Copy link

rhc54 commented Jan 12, 2016

lol - couldn't resist 😺

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1216/ for details.

@jladd-mlnx
Copy link
Member Author

☺️

@yosefe
Copy link
Contributor

yosefe commented Jan 13, 2016

we need to have mca parameter to enable/disable

@rhc54
Copy link

rhc54 commented Jan 13, 2016

@yosefe We already have a param for this purpose, I believe: mpi_add_procs_cutoff is what is used elsewhere, if I understand this PR correctly. Would it work for you here?

@jladd-mlnx
Adding support for dynamic endpoint creation
92c86e1 
Signed-off-by: Tomislav Janjusic <tomislavj@mngx-apl-01.mtl.labs.mlnx>
Signed-off-by: Tomislavj Janjusic <tomislavj@mellanox.com>
Signed-off-by: Joshua Ladd <jladd.mlnx@gmail.com>

13/1/2016 - Amended the commit to address reviewer comments.
@jladd-mlnx
Copy link
Member Author

bot:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1220/ for details.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1221/ for details.

@jladd-mlnx
Copy link
Member Author

@miked-mellanox @yosefe @janjust please review.

@mike-dubman
Copy link
Member

👍

@yosefe
Copy link
Contributor

yosefe commented Jan 14, 2016

👍

@ompiteam-bot
Copy link

OMPIBot error: Label "reviewed" is already set on issue 891.

@yosefe
Copy link
Contributor

yosefe commented Jan 14, 2016

@janjust @jladd-mlnx please add the fixes to master as well

jladd-mlnx added a commit to open-mpi/ompi that referenced this pull request Jan 14, 2016
@jladd-mlnx
Addressing reviewers' comments for open-mpi/ompi-release#891
afa62d8
@hppritcha
Copy link
Member

Are the new commits in this PR based on feedback going to go back in to master?

@hppritcha hppritcha added this to the v2.0.0 milestone Jan 14, 2016
@jladd-mlnx
Copy link
Member Author

@hppritcha Yes, and I added the relevant hash to cross reference against in the first comment. See above.

@jladd-mlnx
Adding support for dynamic endpoint creation
7e8fab2 
Signed-off-by: Tomislav Janjusic <tomislavj@mngx-apl-01.mtl.labs.mlnx>
Signed-off-by: Tomislavj Janjusic <tomislavj@mellanox.com>
Signed-off-by: Joshua Ladd <jladd.mlnx@gmail.com>

13/1/2016 - Amended the commit to address reviewer comments.

14/1/2016 - One more amendment to fix undefined symbol error.
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1223/ for details.

hppritcha added a commit that referenced this pull request Jan 15, 2016
@hppritcha
Merge pull request #891 from jladd-mlnx/topic/ucx-direct-modex-capabi…
2bfe411 
…lity

Adding support for dynamic endpoint creation
@hppritcha hppritcha merged commit 2bfe411 into open-mpi:v2.x Jan 15, 2016
bosilca pushed a commit to bosilca/ompi that referenced this pull request Oct 3, 2016
@jladd-mlnx @bosilca
Addressing reviewers' comments for open-mpi/ompi-release#891
cad3ed0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement reviewed RM-Approved

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@jladd-mlnx @rhc54 @mellanox-github @yosefe @mike-dubman @ompiteam-bot @hppritcha @janjust @jsquyres