This repository was archived by the owner on Sep 30, 2022. It is now read-only.
v2.0.0: usnic fixes #934
Merged
v2.0.0: usnic fixes #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Test PASSed. |
Messages should go on the data channel, even if they're short. Only ACKs go on the priority channel. (cherry picked from commit open-mpi/ompi@4de4a26)
Sequence numbers will wrap around; it is not sufficient to check for (seq-1) -- must use the SEQ_DIFF macro to properly handle the wraparound. This bug wasn't serious; it just meant we might retransmit one or two extra times when retransmits were triggerd and the sequence numbers wrapped around their sliding windows. (cherry picked from commit open-mpi/ompi@d624e0d)
Add endpoints in a blocked manner so that we don't overrun the fi_av_insert() event queue. Also make the AV EQ length an MCA param, and report it in mca_btl_base_verbose >=5 output. (cherry picked from commit open-mpi/ompi@db825ab)
(cherry picked from commit open-mpi/ompi@797d502)
A bunch of empirical testing has shown that increasing the retranmit timeout from 1ms to 5ms doesn't adversely affect performance, yet decreases the number of gratuitious retransmissions. (cherry picked from commit open-mpi/ompi@c2615a4)
jsquyres
force-pushed
the
pr/v2.0.0/usnic-fixes
branch
from
0f881db to
fcad142
Compare
|
Test PASSed. |
Three minor updates from the code review of open-mpi#933: * Remove an extra blank line a show_help message * We no longer allow -1 for the MCA param btl_usnic_av_eq_num, so change the flag to REGINT_GE_ONE * Change "num_blocks" definition to be in terms of block_len (not eq_size) (cherry picked from commit open-mpi/ompi@9f3ed00)
|
Pushed one additional commit as a result of @bturrubiates's review. Ben now gives a 👍 for this PR. |
|
Test PASSed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v2.x PR of #933 (i.e., it's the same, but for the v2.x branch).
@bturrubiates Please review