Skip to content

Commit

Permalink
Fix inconsistent configure-time Fortran TKR check
Browse files Browse the repository at this point in the history
This fixes the inconsistency between what is tested at the configure time (the
unnamed Fortran interface) and what is actually used in the source code (the
named Fortran interface).

As was mentioned in #9445, the unnamed interfaces are more forgiving when it
comes to TKR mismatches. Therefore, the current configure-time check is not
strict enough and is prone to giving false results (e.g. for NVHPC 23.3+). The
fix is to switch to the named Fortran interface in the configure script.

Note that the inconsistency was resolved in the main branch with #9445, which we
cannot cherry-pick because it potentially breaks the ABI compatibility.

Signed-off-by: Sergey Kosukhin <sergey.kosukhin@mpimet.mpg.de>
  • Loading branch information
skosukhin committed Aug 21, 2023
1 parent 31dd49a commit 5b4ee66
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/ompi_fortran_check_ignore_tkr.m4
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ AC_DEFUN([OMPI_FORTRAN_CHECK_IGNORE_TKR_SUB], [
end subroutine force_assumed_shape
end interface

interface
interface foo
subroutine foo(buffer, count)
$1 buffer
$2, intent(in) :: buffer
Expand Down

0 comments on commit 5b4ee66

Please sign in to comment.