Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1.x: opal Segfault avoidence in class and mca/btl/ofi #10461

Conversation

joshfisher-cornelisnetworks
Copy link
Contributor

@joshfisher-cornelisnetworks joshfisher-cornelisnetworks commented Jun 9, 2022

Fixed a loop causing segfaults in opal_object.h and fixed goto fail
block to check for NULL before potential dereference as we go there
for NULL in what we dereference

Signed-off-by: Josh Fisher josh.fisher@cornelisnetworks.com

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@jsquyres
Copy link
Member

jsquyres commented Jun 9, 2022

@joshfisher-cornelisnetworks Our pattern is to PR fixes to main first and then cherry pick them to relevant branches. If the fix isn't relevant for main, then you can put bot:notacherrypick in the PR description (and then please provide an explanation in the commit message as to why it's not a cherry pick).

Thanks.

@jsquyres jsquyres added this to the v4.1.5 milestone Jun 9, 2022
@jsquyres
Copy link
Member

jsquyres commented Jun 9, 2022

Refs #10370

Fixed a loop causing segfaults in opal_object.h and fixed goto fail
block to check for NULL before potential dereference as we go there
for NULL in what we dereference

Signed-off-by: Josh Fisher <josh.fisher@cornelisnetworks.com>
@joshfisher-cornelisnetworks
Copy link
Contributor Author

Changing request to target main and will cherry-pick back.

@jsquyres
Copy link
Member

@joshfisher-cornelisnetworks Thanks. FWIW, you could have opened a new master PR, got that one merged, and then added the cherry pick message here in this PR's commit message. Git doesn't actually track cherry picks in its internal structure; it's just the magic commit message token that we're looking for. These commit message tokens help us ensure that we have gotten all the relevant fixes from main to the release branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants