-
Notifications
You must be signed in to change notification settings - Fork 927
Export MPI_VERSION to docs. #10748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export MPI_VERSION to docs. #10748
Conversation
Move the parsing to autogen time, so configure can grab it and export it. Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
d64407c
to
3b8150e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't want to change most of the "MPI-3.1" references in the man pages, because they refer to specific sections in the MPI-3.1 document, which may (did) change in other versions of the MPI document.
@jsquyres The rationale for a lot of these is once we claim v4.0 support, we would update these references to the new v4.0 sections if they change. Right now we claim v3.1 support, so it makes sense that we reference the v3.1 sections, but I can change any that don't make sense to change. |
I hear what you're saying, but you'll somehow also need to update the section numbers for the MPI-4.0 doc, too. Otherwise, the content becomes factually incorrect. That being said, even though it's "odd", it's technically correct to still cite the MPI-3.1 doc and a specific section in it: that's a fixed reference, and is still correct, even if Open MPI supports MPI-4.0. |
Correct - before upping the version to v4.0 (this PR does not change the version - just makes sure it's propagated) - these references will need to be updated to the correct section. I figured that is just something we should do anyway, once we claim v4.0 support and are ready to bump the actual version. 🤷 Anyway - I can revert this commit if is more trouble than it is worth. |
3b8150e
to
7e195fb
Compare
Let's remove all the places where you changed "MPI-3.1 section xyz...", and leave that as a fixed, hard-coded reference. There were a few places where it was ok to update to MPI-|mpi_version|.|mpi_subversion|. |
7e195fb
to
bf1e3ad
Compare
Done |
@jsquyres is this good to go? |
Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
bf1e3ad
to
abe62d2
Compare
@jsquyres I made that change, but you might want to refresh as it seems you might be looking at a stale version. The spawn_multiple file is not touched anymore. |
bot:aws:retest |
No description provided.