Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHMEM_LOCKS: MCS implementation of SHMEM LOCKS #12003

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

vvenkates27
Copy link
Contributor

Adding MCS algorithm-based implementation for shmem_locks to improve performance for large scale SHMEM applications using locks. MCS lock is now the default algorithm, use the following MCA parameter to disable. --mca oshmem_enable_mcs_lock 0 to disable mcs locks and revert to default ticket locking. --mca oshmem_api_verbose 10 for debug information on shmem_locks.
@brminich @manjugv @yosefe

@github-actions github-actions bot added this to the v5.0.0 milestone Oct 18, 2023
@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

222593d: SHMEM_LOCKS: MCS implementation of SHMEM LOCKS

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

Adding MCS algorithm-based implementation for shmem_locks
to improve performance for large scale SHMEM applications using locks.
MCS lock is now the default algorithm, use the following MCA parameter
to disable.

--mca oshmem_enable_mcs_lock 0 to disable mcs locks and
revert to default ticket locking.

--mca oshmem_api_verbose 10 for debug
information on shmem_locks.

Signed-off-by: Vishwanath Venkatesan <vvenkatesan@nvidia.com>
(cherry picked from commit 1396585)
@vvenkates27
Copy link
Contributor Author

@brminich @yosefe Please review. Thanks

@janjust janjust requested review from brminich and yosefe October 18, 2023 14:25
@jsquyres jsquyres modified the milestones: v5.0.0, v5.0.1 Oct 30, 2023
@janjust janjust merged commit 934e241 into open-mpi:v5.0.x Nov 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants