V5.0.x: Avoid static initialization of recursive mutexes #12057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no portable way to statically initialize recursive mutexes. Where possible avoid doing so, and where not possible add a specialized __constructor__ (thanks @eschnett for the patch). Fixes open-mpi#12029. Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit ad4c825)
The only remaining statically initialized recursive mutex has now support for the constructor attribute. Signed-off-by: George Bosilca <bosilca@icl.utk.edu> (cherry picked from commit 787dd7b)
devreal
approved these changes
Nov 10, 2023
lrbison
pushed a commit
to lrbison/ompi
that referenced
this pull request
Feb 20, 2024
Previously it was in component_init, but after open-mpi#12057 I noticed MPI finalize would find an uninitialized object and segfault. This change moves the initialization to component_open, so that component_close() can rely on the opal object initialization having been completed. Signed-off-by: Luke Robison <lrbison@amazon.com>
lrbison
pushed a commit
to lrbison/ompi
that referenced
this pull request
Feb 24, 2024
Previously it was in component_init, but after open-mpi#12057 I noticed MPI finalize would find an uninitialized object and segfault. This change moves the initialization to component_open, so that component_close() can rely on the opal object initialization having been completed. Signed-off-by: Luke Robison <lrbison@amazon.com> (cherry picked from commit 5ff314c)
jiaxiyan
pushed a commit
to jiaxiyan/ompi
that referenced
this pull request
Mar 1, 2024
Previously it was in component_init, but after open-mpi#12057 I noticed MPI finalize would find an uninitialized object and segfault. This change moves the initialization to component_open, so that component_close() can rely on the opal object initialization having been completed. Signed-off-by: Luke Robison <lrbison@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no portable way to statically initialize recursive mutexes. Where possible avoid doing so, and where not possible add a specialized constructor (thanks @eschnett for the patch).
Fixes #12029.