Revert https://github.com/open-mpi/ompi/pull/10959 #12094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
approved these changes
Nov 17, 2023
hppritcha
approved these changes
Nov 17, 2023
Contributor
Author
|
@hppritcha shall we merge? AWS is actually testing the main branch. We are currently broken since we didn't implement the function pointers - this PR will fix that. |
Member
|
we need to get you write permissions :-) |
Contributor
Author
|
I got that on 5.0 branch yesterday - there are enough people for main. I feel comfortable bugging you folks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12091
We want to discuss the possibility of use object destructors and possibly avoid unnecessary destroy* APIs