Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pml/ucx: Propagate MPI serialized thread mode #12613

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

tvegas1
Copy link
Contributor

@tvegas1 tvegas1 commented Jun 11, 2024

backport #12608 from v5.0.x

Also added osc/ucx thread mode and tested with mpirun -mca osc ucx osu_get_latency.

tvegas1 added 2 commits June 11, 2024 09:40
Move MPI to UCX thread mode function to common source. Also use
serialized mode for all oshmem initializations.

Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
(cherry picked from commit 44cc663)
Move MPI to UCX thread mode function to common source. Also use
serialized mode for all oshmem initializations.

Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
(cherry picked from commit 44cc663)
@github-actions github-actions bot added this to the v4.1.7 milestone Jun 11, 2024
@tvegas1
Copy link
Contributor Author

tvegas1 commented Jun 11, 2024

@brminich, @yosefe, @bosilca can you please review?

Move MPI to UCX thread mode function to common source. Also use
serialized mode for all oshmem initializations.

Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
(cherry picked from commit 44cc663)
@tvegas1
Copy link
Contributor Author

tvegas1 commented Jun 11, 2024

After testing for osc/ucx, retested ucx worker creation init paths using:

  • ompi: MPI_Init_thread()
  • oshmem: shmem_init_thread() and shmem_ctx_create().

ompi/mca/osc/ucx/osc_ucx_component.c Outdated Show resolved Hide resolved
opal/mca/common/ucx/common_ucx.c Outdated Show resolved Hide resolved
Move MPI to UCX thread mode function to common source. Also use
serialized mode for all oshmem initializations.

Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
(cherry picked from commit 44cc663)
@jsquyres jsquyres merged commit 2f4ef91 into open-mpi:v4.1.x Jul 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants