-
Notifications
You must be signed in to change notification settings - Fork 901
Fix some compiler warnings #12685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some compiler warnings #12685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits are not signed. Don't merge before fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sign the commits
They are signed with a |
I thought we did, but after checking the last set of commits it appears we haven't. Most of the regular contributors are either "Verified" or nothing. But somehow you are specifically marked as "Unverified". |
Signed-off-by: Joseph Schuchart <joseph.schuchart@stonybrook.edu>
Signed-off-by: Joseph Schuchart <joseph.schuchart@stonybrook.edu>
Signed-off-by: Joseph Schuchart <joseph.schuchart@stonybrook.edu>
The compiler will otherwise complain about potentially uninitialized variables. Signed-off-by: Joseph Schuchart <joseph.schuchart@stonybrook.edu>
3270274
to
41a1a2f
Compare
I think I have enabled that warning for my commits. Just added my new email address to my GPG key and now it shows as Verified (applies to my prior commits as well) |
@devreal is right: we've just required the signoff line in the commit message -- we haven't required cryptographically-verified commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random selection of compiler warnings found with Clang 17.
The warnings addressed here: