configury: fix IGNORE_TKR check #12745
Conversation
As reported by Chris Parrott in open-mpi#12681, the enhanced test was buggy. Pass the expected argument to make it Fortran compliant and LLVM 17 and above happy compilers Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
There was a problem hiding this comment.
@ggouaillardet Did you make this a draft PR for a reason? Or is it ready to go?
|
I initially made it a draft waiting for CI, and I kept it a draft because it is not ready to go (e.g. it "breaks" At this stage, I would keep things as-is (e.g. close this PR without merging) and add a note we will only support |
|
@cparrott73 Got any suggestions? |
|
@jsquyres @ggouaillardet - let me follow up with this with our Fortran experts. |
|
@cparrott73 just checking if you had time to follow up with the Fortran guys? |
Sorry, have been dealing with a few fires this week. I pinged our Fortran folks on Slack about this, and referenced this PR. Hopefully they will either chime in here or let me know what their thoughts are. |
As reported by Chris Parrott in #12681, the enhanced test was buggy. Pass the expected argument to make it Fortran compliant and LLVM 17 and above happy compilers