Update hwloc to 1.11.2 + Fix #1289
Conversation
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
@hppritcha This fixes an error message printed out on Trinity due to abnormally long /proc/mounts lines. I discussed this with @jsquyres and it should be good to go into v2.0.0. Will open the PR as soon as this is merged on master. |
|
@hjelmn Can you add a README-ompi.txt file in the new component directory that contains the hash of the commit that you cherry-picked? That helps us track it (especially if the git commit logs aren't available for whatever reason). Thanks. |
setmntent() doesn't support root_fd, but manual parsing of /proc/mounts is fragile, and actually buggy for very long mount lines (see open-mpi/hwloc#142 (comment)). Since we only openat("/proc/mounts") there, just manually concatenate the fsroot_path and use setmntent(). Thanks to Nathan Hjelm for the report. (Cherry-picked from open-mpi/hwloc@d2d07b9) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
@jsquyres Added to the second commit. |
|
@jsquyres Looks like this is good to go if you are ok with it. |
|
@hppritcha I'm good with this. It fixes a real bug on the Cray systems, and fixes whatever other bugs hwloc fixed from 1.11.1 to 1.11.2. Sound ok to you? |
|
👍 |
|
Ok, will merge and open for v2.0.0. |
Update hwloc to 1.11.2 + Fix /proc/mounts issue.
…-message-update help-orterun: remove blank line at end of help message
7 participants
This update brings hwloc up to 1.11.2 and brings in a bug fix for Cray systems.