Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
125 commits
Select commit Hold shift + click to select a range
7e425a4
Add initial ABI generation code and new libraries
jtronge Sep 28, 2023
eebd824
Move ABI support into big count binding code
hppritcha May 10, 2025
1881940
bindings: fix up makefile for c interfaces
hppritcha May 28, 2025
20c973b
makefile fixes
hppritcha May 29, 2025
772b08c
checkpoint
hppritcha Jun 2, 2025
50e1f7d
some fixes and start of a wrapper method
hppritcha Jul 2, 2025
5a652c6
attributes: add wrapper infrastructure
hppritcha Jul 7, 2025
3257cb5
abi: move converter functions to a persistent file
hppritcha Jul 29, 2025
a449c28
minor compiler complaint fix
hppritcha Jul 29, 2025
2b9eaa8
temp commit with comments notes
hppritcha Aug 12, 2025
2302419
Switch to using MPI Standard ABI values
Joe-Downs Jun 26, 2025
d40150d
distcheck fix and more
hppritcha Aug 21, 2025
3a65c12
git ignore additions
hppritcha Aug 23, 2025
44b620e
ABI library: don't include functions in 19.3.4/5
hppritcha Aug 23, 2025
a6da325
fixes to handle count/offset/aint in abi.h
hppritcha Aug 25, 2025
5fac420
fix req converter abi to ompi
hppritcha Aug 26, 2025
39491dd
fix problem with request_get_status_some
hppritcha Aug 26, 2025
fbd0788
bindings: fix up REQUEST_CONST for abi
hppritcha Aug 26, 2025
03250b6
tools: first steps to add support for ABI
hppritcha Sep 2, 2025
fca68c3
fix problem with undefined symbols in libmpi_abi
hppritcha Sep 2, 2025
360a2d7
hack on abi json file
hppritcha Sep 3, 2025
9bd8e9f
abi.h template - add MPI_T related structs
hppritcha Sep 3, 2025
143e5b3
binding framework: fixes for MPI T stuff
hppritcha Sep 3, 2025
3ba5c08
binding framework: add a TS_LEVEL type
hppritcha Sep 3, 2025
fa5de6a
more hacks on the mpi-standard-5.0-abi.json
hppritcha Sep 3, 2025
e0c4614
fix for enable-mca-dso
hppritcha Sep 3, 2025
76265a4
makefile changes to add symbols to libmpi_abi
hppritcha Sep 16, 2025
b99a3af
abi: fix problems with error handler converters
hppritcha Sep 17, 2025
479147b
fix problems with makefiles and some symbols
hppritcha Sep 17, 2025
5981a87
abi: move mpi_type_get_envelope etc. into templates
hppritcha Sep 18, 2025
e0af62a
rebase fixup
hppritcha Sep 19, 2025
2231aab
add abi variantes of mpi_aint_diff and add
hppritcha Sep 19, 2025
5d15192
add abi_set/get_fortran_info
hppritcha Sep 19, 2025
d9c25b7
abi_fortran_stuff: fix up the imp of these
hppritcha Sep 22, 2025
2df3922
abi_converters: add fortran datatypes to
hppritcha Sep 22, 2025
a584be1
fix for mac-os CI
hppritcha Sep 23, 2025
fcd00af
pr feedback on add/diff for aints
hppritcha Sep 23, 2025
126c14a
configury: discover fortran logical false
hppritcha Sep 23, 2025
acebae0
configury fix
hppritcha Sep 23, 2025
5a3d235
squashme: temporary commit
hppritcha Sep 23, 2025
79385ef
add abi_get/set_fortran_booleans c interfaces
hppritcha Sep 25, 2025
73ba61b
abi_fortran: add support for LOGICAL16
hppritcha Sep 25, 2025
d7d0d9b
logical16 patch
hppritcha Sep 29, 2025
e525beb
add comm_from/toint
hppritcha Sep 29, 2025
908d1b8
complete toint/fromint interfaces
hppritcha Oct 1, 2025
c837bbb
fix error return values for ABI routines
hppritcha Oct 1, 2025
c3c500b
minor fixup for toint/fromint
hppritcha Oct 1, 2025
1ac6657
rebase fix
hppritcha Oct 1, 2025
12c623f
handle TAG more correctly
hppritcha Oct 1, 2025
6650e86
squash compiler warning
hppritcha Oct 1, 2025
a444b9b
add hooks for TAG_OUT type
hppritcha Oct 1, 2025
026df5f
add better support for MPI_ROOT and source
hppritcha Oct 1, 2025
ae72028
squash a compiler warning
hppritcha Oct 2, 2025
9eba648
some fixes to comm attributes wrappers
hppritcha Oct 3, 2025
47a6e9e
fix bug in comm attr copy code
hppritcha Oct 3, 2025
931430f
some fixes for attributes and more
hppritcha Oct 7, 2025
528e5e9
checkpoint
hppritcha Oct 9, 2025
47f9c3b
fix for datatype converters
hppritcha Oct 9, 2025
8385db5
distcheck fix
hppritcha Oct 9, 2025
c3a4451
EVENT_INSTANCE: arg type cast fix
hppritcha Oct 9, 2025
b8f8e4c
MPI_ROOT: capture proc null type too
hppritcha Oct 9, 2025
667db71
requests: fixes to some multirequest test functions
hppritcha Oct 10, 2025
97c71d2
weights and source out support/fixes
hppritcha Oct 10, 2025
1f0254a
some fixes for message related functions
hppritcha Oct 11, 2025
d86c6e4
fix mpi4py break
hppritcha Oct 11, 2025
949868f
fix a few problems with datatype bindings
hppritcha Oct 11, 2025
b86d21e
update gitignore
hppritcha Oct 11, 2025
d0b9d14
add replacements to code bodies for various string lengths
hppritcha Oct 13, 2025
b18a8a5
add support for distrib array and order
hppritcha Oct 13, 2025
117356e
add support for mode bits - in only
hppritcha Oct 13, 2025
fd1a0a8
add support for amode out
hppritcha Oct 13, 2025
57094ab
add support for whence
hppritcha Oct 14, 2025
311eadd
add support for some win attributes
hppritcha Oct 14, 2025
e8ea562
handle special case of MPI_DISPLACEMENT_CURRENT
hppritcha Oct 14, 2025
5df6bae
add support for combiner, typeclass, win lock assert
hppritcha Oct 14, 2025
8f7628b
c_header: comment out deprecated functions
hppritcha Oct 15, 2025
6009f50
fix problem with special attrs for windows
hppritcha Oct 15, 2025
4f2aecf
fix for win_shared_query
hppritcha Oct 15, 2025
869c1a2
fixes to rget/rget_accumulate
hppritcha Oct 16, 2025
e08a17a
fix problem with code gen for win create keyval
hppritcha Oct 16, 2025
12e750a
fix rank problem in rput/raccumulate
hppritcha Oct 16, 2025
4fcf510
add MPI_GROUP_EMPTY to predefined group handles
hppritcha Oct 16, 2025
f707467
handle user error classes and codes
hppritcha Oct 16, 2025
220739a
temporary WAR for non-blocking alltoallw
hppritcha Oct 20, 2025
7d6fa88
add support for comm topos
hppritcha Oct 20, 2025
e39a31b
support INOUT attribute for all handles
hppritcha Oct 20, 2025
db8111c
fix problem with attribute callback handling
hppritcha Oct 20, 2025
e342404
catch use of special buffer consts
hppritcha Oct 21, 2025
353ad35
remove some debug statements
hppritcha Oct 21, 2025
43624b7
swat nit
hppritcha Oct 21, 2025
b691dac
patch get_address
hppritcha Oct 21, 2025
1a962e6
add new type to handle out void stars
hppritcha Oct 21, 2025
f3bfbf3
fixes for datatypes for neighbor collectives
hppritcha Oct 21, 2025
dc5e23d
add inouts for op, errhandler, info
hppritcha Oct 22, 2025
a3c7260
cleanup datatype tmps for ialltoallw and friends
hppritcha Oct 22, 2025
3375287
a logical16 fix
hppritcha Oct 22, 2025
0a36325
abi_get_version/get_info add to ompi abi lib
hppritcha Oct 22, 2025
0c3cbde
toint fixes
hppritcha Oct 23, 2025
f9f6acd
fix issue with ASYNC data arrays cleanup
hppritcha Oct 24, 2025
ddb6d74
various fixes from dalcinl
hppritcha Oct 24, 2025
27c2e6a
fix a problem
hppritcha Oct 24, 2025
15092ef
ompi-codegen.patch from dalcinl
hppritcha Oct 24, 2025
d165aed
ompi-abiinfo.patch from dalcinl
hppritcha Oct 24, 2025
3126f86
ompi-status.patch from dalcinl
hppritcha Oct 25, 2025
d56b5e6
move some deprecated funcs out of libmpi-abi
hppritcha Oct 27, 2025
4694f63
add support for typeclass
hppritcha Oct 27, 2025
ce93d8c
ops: convert data from internal to abi
hppritcha Oct 27, 2025
5f27c44
split rdma modes out from modes for files
hppritcha Oct 27, 2025
f738ba1
add SOURCE_ARRAY type
hppritcha Oct 27, 2025
0704146
fixes to abi_get_fortran_info
hppritcha Oct 28, 2025
d6baa28
apply patch omp-op-inout.patch
hppritcha Oct 29, 2025
0b710d6
apply patch ompi-abi-fortran.patch
hppritcha Oct 29, 2025
34df931
fix for FD_INOUT
hppritcha Oct 29, 2025
9e79d60
fix for isend dst arg
hppritcha Oct 29, 2025
1688d76
apply patch ompi-query-thread.patch
hppritcha Oct 29, 2025
06cc3ea
various pt2pt fixes to handle proc_null etc.
hppritcha Oct 30, 2025
edbe8e5
rma: updates to args to handle proc_null etc
hppritcha Oct 30, 2025
bc73bac
adjustments for improbe and iprobe
hppritcha Oct 30, 2025
9153ff7
fix for status array for MPI_Request_testsome
hppritcha Oct 30, 2025
60275b5
switch to using a malloc wrapper
hppritcha Nov 2, 2025
eeca33f
plug memory leak handling REQUEST_INOUT type
hppritcha Nov 2, 2025
a33ccb8
patch status out to handle copy in
hppritcha Nov 3, 2025
7b7f032
handle dargs for darray_create correctly
hppritcha Nov 4, 2025
b8535be
fixes for spawn multiple - array of info args
hppritcha Nov 4, 2025
53dc796
disable async NBC-based cleanup for now
hppritcha Nov 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ ompi/tools/ompi_info/ompi_info

ompi/tools/wrappers/mpic++-wrapper-data.txt
ompi/tools/wrappers/mpicc-wrapper-data.txt
ompi/tools/wrappers/mpicc_abi-wrapper-data.txt
ompi/tools/wrappers/mpifort-wrapper-data.txt
ompi/tools/wrappers/ompi_wrapper_script
ompi/tools/wrappers/ompi.pc
Expand Down Expand Up @@ -534,6 +535,12 @@ docs/man

# Generated C Bindings
ompi/mpi/c/*_generated*.c
ompi/mpi/c/standard_*.c
ompi/mpi/c/abi.h
ompi/mpi/c/abi_get_info.c
ompi/mpi/c/abi_converters.h
ompi/mpi/c/standard_abi
ompi/mpi/tool/*_generated*.c

# Generated Fortran Bindings
ompi/mpi/fortran/use-mpi-f08/*_generated.F90
Expand Down
1 change: 1 addition & 0 deletions config/ompi_config_files.m4
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ AC_DEFUN([OMPI_CONFIG_FILES],[
ompi/tools/ompi_info/Makefile
ompi/tools/wrappers/Makefile
ompi/tools/wrappers/mpicc-wrapper-data.txt
ompi/tools/wrappers/mpicc_abi-wrapper-data.txt
ompi/tools/wrappers/mpic++-wrapper-data.txt
ompi/tools/wrappers/mpifort-wrapper-data.txt
ompi/tools/wrappers/ompi.pc
Expand Down
26 changes: 25 additions & 1 deletion config/ompi_configure_options.m4
Original file line number Diff line number Diff line change
Expand Up @@ -256,5 +256,29 @@ AM_CONDITIONAL(OMPI_OMPIO_SUPPORT, test "$ompi_want_ompio" = "1")
AC_ARG_ENABLE([deprecate-mpif-h],
[AS_HELP_STRING([--enable-deprecate-mpif-h],
[Mark the mpif.h bindings as deprecated (default: enabled)])])

# If the binding source files don't exist, then we need Python to generate them
AM_PATH_PYTHON([3.6],,[:])
binding_file="${srcdir}/ompi/mpi/c/ompi_send_generated.c"
AS_IF([! test -e "$binding_file" && test "$PYTHON" = ":"],
[AC_MSG_ERROR([Open MPI requires Python >=3.6 for generating the bindings. Aborting])])
AM_CONDITIONAL(OMPI_GENERATE_BINDINGS,[test "$PYTHON" != ":"])

AC_MSG_CHECKING([if want to enable standard ABI library])
AC_ARG_ENABLE([standard-abi],
[AS_HELP_STRING([--enable-standard-abi],
[Enable building the standard ABI library (default: enabled)])])
if test "$enable_standard_abi" = "no"; then
AC_MSG_RESULT([no])
ompi_standard_abi=0
else
AC_MSG_RESULT([yes])
ompi_standard_abi=1
fi
AC_DEFINE_UNQUOTED([OMPI_STANDARD_ABI],[$ompi_standard_abi],
[Whether we want to build the standard ABI library])
AM_CONDITIONAL(OMPI_STANDARD_ABI,[test $ompi_standard_abi = 1])
AS_IF([test $ompi_standard_abi -eq 1],
[gen_abi="yes"],
[gen_abi="no"])
OPAL_SUMMARY_ADD([Miscellaneous], [MPI Standard ABI support], [], [$gen_abi])
])dnl
4 changes: 3 additions & 1 deletion config/ompi_fortran_check_logical_array.m4
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ dnl All rights reserved.
dnl Copyright (c) 2011-2012 Cisco Systems, Inc. All rights reserved.
dnl Copyright (c) 2015 Research Organization for Information Science
dnl and Technology (RIST). All rights reserved.
dnl Copyright (c) 2025 Triad National Security, LLC. All rights
dnl reserved.
dnl $COPYRIGHT$
dnl
dnl Additional copyrights may follow
Expand Down Expand Up @@ -64,7 +66,7 @@ void ompi_check_f(ompi_fortran_logical_t * logical)
FILE *f=fopen("conftestval", "w");
if (!f) exit(1);

if (logical[[0]] == 0 &&
if (logical[[0]] == $ompi_cv_fortran_false_value &&
logical[[1]] == $ompi_cv_fortran_true_value)
result = 1;
fprintf(f, "%d\n", result);
Expand Down
60 changes: 56 additions & 4 deletions config/ompi_fortran_get_value_true.m4
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ dnl All rights reserved.
dnl Copyright (c) 2011-2012 Cisco Systems, Inc. All rights reserved.
dnl Copyright (c) 2015 Research Organization for Information Science
dnl and Technology (RIST). All rights reserved.
dnl Copyright (c) 2025 Triad National Security, LLC. All rights
dnl reserved.
dnl $COPYRIGHT$
dnl
dnl Additional copyrights may follow
Expand All @@ -27,16 +29,22 @@ AC_DEFUN([OMPI_FORTRAN_GET_VALUE_TRUE],[
if test "$ompi_cv_fortran_true_value" = "0" ; then
unset ompi_cv_fortran_true_value
fi
if test "$ompi_cv_fortran_false_value" = "0" ; then
unset ompi_cv_fortran_false_value
fi

AS_VAR_PUSHDEF([fortran_true_var],
[ompi_cv_fortran_true_value])
AS_VAR_PUSHDEF([fortran_false_var],
[ompi_cv_fortran_false_value])

AC_CACHE_CHECK([Fortran value for .TRUE. logical type],
fortran_true_var,
[if test "$1" = "none" || \
test $OMPI_TRY_FORTRAN_BINDINGS -eq $OMPI_FORTRAN_NO_BINDINGS || \
test $ompi_fortran_happy -eq 0 ; then
value=77
tvalue=77
fvalue=77
else
#
# C module
Expand Down Expand Up @@ -98,6 +106,14 @@ EOF
CALL ompi_print(value)
end
EOF
cat > conftestf2.f <<EOF
program main
logical value
value=.FALSE.
CALL ompi_print(value)
end
EOF


#
# Try the compilation and run.
Expand All @@ -114,11 +130,40 @@ EOF
AS_IF([test "$cross_compiling" = "yes"],
[AC_MSG_ERROR([Can not determine value of .TRUE. when cross-compiling])],
[OPAL_LOG_COMMAND([./conftest],
[value=`sed 's/ *//' conftestval`],
[tvalue=`sed 's/ *//' conftestval`],
[AC_MSG_ERROR([Could not determine value of Fotran .TRUE.. Aborting.])])])

cat > conftestf.f <<EOF
program main
logical value
value=.FALSE.
CALL ompi_print(value)
end
EOF

#
# Try the compilation and run.
#
OPAL_LOG_COMMAND([$CC $CFLAGS -I. -c conftest.c],
[OPAL_LOG_COMMAND([$FC $FCFLAGS -o conftest conftest.o conftestf.f $LDFLAGS $LIBS],
[happy=1], [happy=0])],
[happy=0])

AS_IF([test $happy -eq 0 && test $ompi_fortran_happy -eq 1],
[AC_MSG_ERROR([Could not compile Fortran .FALSE. test. Aborting.])
])

AS_IF([test "$cross_compiling" = "yes"],
[AC_MSG_ERROR([Can not determine value of .FALSE. when cross-compiling])],
[OPAL_LOG_COMMAND([./conftest],
[fvalue=`sed 's/ *//' conftestval`],
[AC_MSG_ERROR([Could not determine value of Fotran .FALSE.. Aborting.])])])
fi
AS_VAR_SET(fortran_true_var, [$value])
unset value
AS_VAR_SET(fortran_true_var, [$tvalue])
unset tvalue
AS_VAR_SET(fortran_false_var, [$fvalue])
unset fvalue

])

AS_VAR_COPY([ompi_fortran_true_value], [fortran_true_var])
Expand All @@ -127,6 +172,13 @@ EOF
[Fortran value for LOGICAL .TRUE. value])
AS_VAR_POPDEF([fortran_true_var])

AS_VAR_COPY([ompi_fortran_false_value], [fortran_false_var])
AC_DEFINE_UNQUOTED([OMPI_FORTRAN_VALUE_FALSE],
[$ompi_fortran_false_value],
[Fortran value for LOGICAL .FALSE. value])
AS_VAR_POPDEF([fortran_false_var])


unset happy ompi_print_logical_fn
rm -rf conftest*
])dnl
6 changes: 5 additions & 1 deletion docs/man-openmpi/man3/MPI_Errors.3.rst
Original file line number Diff line number Diff line change
Expand Up @@ -348,9 +348,13 @@ Standard error return classes for Open MPI:
- Value is too large to store.

* - MPI_ERR_ERRHANDLER
- 89
- 80
- Invalid error handler handle.

* - MPI_ERR_ABI
- 81
- Invalid use of ABI method.

* - MPI_ERR_LASTCODE
- 93
- Last error code.
Expand Down
Loading