monitoring lib: rename to ompi_monitoring_prof.so #1390
Conversation
|
The library was never intended to be used by a wider community. It was intended for our internal testing purposes (which explains why we put it in the test directory). I would like to bring this in the 2.x asap. |
|
Should it be a noinst ? Right now, it's installed. Sent from my phone. No type good. |
|
The test itself is installed and will not work without the library. |
|
@bosilca If it's a test, why is the test installed? I.e., you argued both ways: 1) it's a test, and shouldn't be used by anyone, 2) but we install it anyway. My $0.02 -- it either:
|
jsquyres
force-pushed
the
pr/minor-monitoring-library-cleanups
branch
from
a066568 to
795e204
Compare
|
I should have been more clear. The test itself is not installed, but the library is. This library provides the minimal support for using the monitoring PML (via the PMPI interface), it trigger the pvars to generate and save the communication matrix that can be then used for other things (weights for the topology as an example). So, while it is a convenience library, we need it installed in order to be able to play with the topologies. |
|
Let's discuss in person this week. |
|
:bot:retest: |
jsquyres
force-pushed
the
pr/minor-monitoring-library-cleanups
branch
from
795e204 to
2044ade
Compare
|
Test passed. |
|
Please add a Signed-off-by line to this PR's commit. |
jsquyres
force-pushed
the
pr/minor-monitoring-library-cleanups
branch
from
2044ade to
0110260
Compare
The library that is installed is specific to Open MPI, so put an "ompi_" prefix on it. Also do some minor line wrappings and cleanups of text. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
* Use the proper lib prefix name * Use the proper extra LDFLAGS Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/minor-monitoring-library-cleanups
branch
from
0110260 to
c34ba88
Compare
|
PGI CI failure is an internal problem - should be fixed soon. |
|
bot:ibm:pgi:retest |
|
@bosilca I rebased yesterday and merged. |
The library that is installed is specific to Open MPI, so put an "ompi_" prefix on it.
Also do some minor line wrappings and cleanups of text.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
@bosilca I added an "ompi_" prefix to the library name so that it is clear that the installed library is specific to Open MPI, and did some other minor text cleanups. Please review. Did you have a milestone in mind for bringing this monitoring stuff over to the v2.x branch?